From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C5CCC7EE2D for ; Fri, 2 Jun 2023 16:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236796AbjFBQeh (ORCPT ); Fri, 2 Jun 2023 12:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236489AbjFBQed (ORCPT ); Fri, 2 Jun 2023 12:34:33 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B28D4196; Fri, 2 Jun 2023 09:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685723669; x=1717259669; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rnEFNznSwplfZmjgpBx+7PY8r+7rtAddz5y7k6ff+II=; b=F4pPLUwHvtdFEKKA926ZM15XVC0vgeYfAusaGwI46zZvC7gBxP7QRRuP bVdMpThU1ZMMlOydvU8pKcTF1xi4sD7IK0qjTjZ+IggiG2MHopu+ChBoh juYJfiqlHVy809Q2gaCQX8U1A/GWds05zLV7cDLSmWKxS5sqpWpDDNN72 Hu9BSFvTP2AJIO9Xyld0Wljf0BQNEQH1CRmk8wYzm72QqSxNsnRjIIudE KAongCWNVRVhgpJQVGtPf3XqnSTlixRhozViNV7ListKxSi/iWfoMQvWV 96uknMYZpssuQ8sln/CUh3IIB/Wj6Ur/G9bn2hijlApsCUQbyQ1J/moOb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10729"; a="354761729" X-IronPort-AV: E=Sophos;i="6.00,213,1681196400"; d="scan'208";a="354761729" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2023 09:34:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10729"; a="832036141" X-IronPort-AV: E=Sophos;i="6.00,213,1681196400"; d="scan'208";a="832036141" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 02 Jun 2023 09:34:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q57jE-000hvZ-3B; Fri, 02 Jun 2023 19:34:16 +0300 Date: Fri, 2 Jun 2023 19:34:16 +0300 From: Andy Shevchenko To: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Linus Walleij , Bartosz Golaszewski Subject: Re: [PATCH v1 1/1] gpiolib: Do not unexport GPIO on freeing Message-ID: References: <20230602162258.63853-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 02, 2023 at 07:29:00PM +0300, Andy Shevchenko wrote: > On Fri, Jun 02, 2023 at 07:22:58PM +0300, Andy Shevchenko wrote: > > Since the legacy exporting is gone with 2f804aca4832 ("gpiolib: > > Kill unused GPIOF_EXPORT and Co") there is no need to unexport > > GPIO on freeing. Remove that call. > > Note, the other users of this functionality do that explicitly, > > except one SH boardfile which doesn't free GPIO anyways, so it Actually OMAP3 as well with the same idea, once requested those never freed. Bart, should I update the commit message? > > is safe to drop the call. > > Note, that this might be squashed with the above mentioned commit, because > I haven't checked current users I didn't do the removal in that patch. > > But this will probably needs rebase which is not good thing process wise. > So, just my 2 cents in case. -- With Best Regards, Andy Shevchenko