From: andy.shevchenko@gmail.com
To: Astrid Rost <astrid.rost@axis.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Mathieu Othacehe" <m.othacehe@gmail.com>
Subject: Re: [PATCH v5 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200
Date: Sat, 3 Jun 2023 16:46:28 +0300 [thread overview]
Message-ID: <ZHtENLuHKixK884F@surfacebook> (raw)
In-Reply-To: <20230530142405.1679146-5-astrid.rost@axis.com>
Tue, May 30, 2023 at 04:24:02PM +0200, Astrid Rost kirjoitti:
> Add support to configure ambient light sensor interrupts and threshold
> limits for vcnl4040 and vcnl4200. If an interrupt is detected an event
> will be pushed to the event interface.
...
> - int ret;
> + int ret = -EINVAL;
What is the purpose of this change?
...
> - int ret;
> + int ret = -EINVAL;
Ditto.
...
> int ret;
> struct vcnl4000_data *data = iio_priv(indio_dev);
> + switch (chan->type) {
Had you run checkpatch.pl? A definition block and a code should be delimited
by a blank line.
...
> - int ret;
> + int ret = -EINVAL;
Purpose?
...
> - val = state ? (ret | mask) : (ret & ~mask);
> + val = state ? (ret | mask) : (ret & ~mask);
I'm wondering if you can prepere the code by introducing switch-case instead of
current implementation in the preparatory patch and then do what you want to do
here. It will show much better the change and make review easier.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-03 13:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 14:23 [PATCH v5 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 Astrid Rost
2023-05-30 14:23 ` [PATCH v5 1/7] iio: light: vcnl4000: Add proximity irq for vcnl4200 Astrid Rost
2023-06-03 12:08 ` andy.shevchenko
2023-05-30 14:24 ` [PATCH v5 2/7] iio: light: vcnl4000: Add proximity ps_it " Astrid Rost
2023-06-03 12:09 ` andy.shevchenko
2023-05-30 14:24 ` [PATCH v5 3/7] iio: light: vcnl4000: Add als_it for vcnl4040/4200 Astrid Rost
2023-06-03 12:15 ` andy.shevchenko
2023-05-30 14:24 ` [PATCH v5 4/7] iio: light: vcnl4000: add illuminance irq vcnl4040/4200 Astrid Rost
2023-06-03 13:46 ` andy.shevchenko [this message]
2023-06-04 11:16 ` Jonathan Cameron
2023-05-30 14:24 ` [PATCH v5 5/7] iio: light: vcnl4000: Add period for vcnl4040/4200 Astrid Rost
2023-06-03 13:51 ` andy.shevchenko
2023-05-30 14:24 ` [PATCH v5 6/7] iio: light: vcnl4000: Add oversampling_ratio for 4040/4200 Astrid Rost
2023-06-03 13:51 ` andy.shevchenko
2023-05-30 14:24 ` [PATCH v5 7/7] iio: light: vcnl4000: Add calibration bias " Astrid Rost
2023-06-03 13:52 ` andy.shevchenko
2023-06-03 13:54 ` [PATCH v5 0/7] iio: light: vcnl4000: Add features for vncl4040/4200 andy.shevchenko
2023-06-04 11:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHtENLuHKixK884F@surfacebook \
--to=andy.shevchenko@gmail.com \
--cc=astrid.rost@axis.com \
--cc=jic23@kernel.org \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.othacehe@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox