Re: [PATCH v6 1/2] axis-fifo: use devm_kasprintf() for allocating formatted strings

Dan Carpenter
2023-06-20T05:18:16Z

On Mon, Jun 19, 2023 at 09:52:44PM +0530, Prathu Baronia wrote:
> In various places, string buffers of a fixed size are allocated, and
> filled using snprintf() with the same fixed size, which is error-prone.
>
> Replace this by calling devm_kasprintf() instead, which always uses the
> appropriate size.
>
> Signed-off-by: Prathu Baronia <prathubaronia2011@gmail.com>
> ---
> V5 -> V6: Split into api change and name change commits
> V4 -> V5: Remove the dev_info() and use a unique identifier for dev name
> V3 -> V4: Split into warning fixing and cleanup commits
> V2 -> V3: Fix smatch warnings from kernel test robot
> V1 -> V2: Split into logical commits and fix commit message
>

> - snprintf(device_name, 32, "%s_%pa", DRIVER_NAME, &r_mem->start);
^^^

> + device_name = devm_kasprintf(dev, GFP_KERNEL, "%s_%p", DRIVER_NAME, &r_mem->start);
^^

This is a sneaky fix which Greg already kind of complained about if I
remember correctly...

regards,
dan carpenter