From: Simon Horman <simon.horman@corigine.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, loic.poulain@linaro.org
Subject: Re: [PATCH 1/3] net: Add MHI Endpoint network driver
Date: Wed, 7 Jun 2023 10:20:39 +0200 [thread overview]
Message-ID: <ZIA910jCjl+dxc/a@corigine.com> (raw)
In-Reply-To: <20230606123119.57499-2-manivannan.sadhasivam@linaro.org>
On Tue, Jun 06, 2023 at 06:01:17PM +0530, Manivannan Sadhasivam wrote:
...
> +static void mhi_ep_net_dev_process_queue_packets(struct work_struct *work)
> +{
> + struct mhi_ep_net_dev *mhi_ep_netdev = container_of(work,
> + struct mhi_ep_net_dev, xmit_work);
> + struct mhi_ep_device *mdev = mhi_ep_netdev->mdev;
> + struct sk_buff_head q;
> + struct sk_buff *skb;
> + int ret;
> +
> + if (mhi_ep_queue_is_empty(mdev, DMA_FROM_DEVICE)) {
> + netif_stop_queue(mhi_ep_netdev->ndev);
> + return;
> + }
> +
> + __skb_queue_head_init(&q);
> +
> + spin_lock_bh(&mhi_ep_netdev->tx_lock);
> + skb_queue_splice_init(&mhi_ep_netdev->tx_buffers, &q);
> + spin_unlock_bh(&mhi_ep_netdev->tx_lock);
> +
> + while ((skb = __skb_dequeue(&q))) {
> + ret = mhi_ep_queue_skb(mdev, skb);
> + if (ret) {
Hi Manivannan,
I wonder if this should be kfree_skb(skb);
> + kfree(skb);
> + goto exit_drop;
> + }
...
next prev parent reply other threads:[~2023-06-07 8:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 12:31 [PATCH 0/3] Add MHI Endpoint network driver Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 1/3] net: " Manivannan Sadhasivam
2023-06-07 8:20 ` Simon Horman [this message]
2023-06-07 11:21 ` Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 2/3] MAINTAINERS: Add entry for MHI networking drivers under MHI bus Manivannan Sadhasivam
2023-06-06 12:31 ` [PATCH 3/3] net: mhi: Increase the default MTU from 16K to 32K Manivannan Sadhasivam
2023-06-06 13:50 ` Jeffrey Hugo
2023-06-07 6:58 ` Manivannan Sadhasivam
2023-06-07 12:25 ` Andrew Lunn
2023-06-07 14:56 ` Manivannan Sadhasivam
2023-06-07 8:21 ` Simon Horman
2023-06-06 12:59 ` [PATCH 0/3] Add MHI Endpoint network driver Andrew Lunn
2023-06-07 6:56 ` Manivannan Sadhasivam
2023-06-07 7:12 ` Loic Poulain
2023-06-07 7:41 ` Manivannan Sadhasivam
2023-06-07 12:28 ` Andrew Lunn
2023-06-07 14:19 ` Jeffrey Hugo
2023-06-06 21:22 ` Jakub Kicinski
2023-06-07 7:03 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIA910jCjl+dxc/a@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox