* [PATCH net v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add()
@ 2023-06-07 2:23 Hangyu Hua
2023-06-07 7:15 ` Larysa Zaremba
2023-06-07 11:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Hangyu Hua @ 2023-06-07 2:23 UTC (permalink / raw)
To: jhs, xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni,
simon.horman, larysa.zaremba
Cc: netdev, linux-kernel, Hangyu Hua
try_module_get will be called in tcf_proto_lookup_ops. So module_put needs
to be called to drop the refcount if ops don't implement the required
function.
Fixes: 9f407f1768d3 ("net: sched: introduce chain templates")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
---
v2: fix the patch description.
net/sched/cls_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index 2621550bfddc..92bfb892e638 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -2952,6 +2952,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net,
return PTR_ERR(ops);
if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {
NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier");
+ module_put(ops->owner);
return -EOPNOTSUPP;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add()
2023-06-07 2:23 [PATCH net v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add() Hangyu Hua
@ 2023-06-07 7:15 ` Larysa Zaremba
2023-06-07 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Larysa Zaremba @ 2023-06-07 7:15 UTC (permalink / raw)
To: Hangyu Hua
Cc: jhs, xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni,
simon.horman, netdev, linux-kernel
On Wed, Jun 07, 2023 at 10:23:01AM +0800, Hangyu Hua wrote:
> try_module_get will be called in tcf_proto_lookup_ops. So module_put needs
> to be called to drop the refcount if ops don't implement the required
> function.
>
> Fixes: 9f407f1768d3 ("net: sched: introduce chain templates")
Reviewed-by: Larysa Zaremba <larysa.zaremba@intel.com>
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
>
> v2: fix the patch description.
>
> net/sched/cls_api.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
> index 2621550bfddc..92bfb892e638 100644
> --- a/net/sched/cls_api.c
> +++ b/net/sched/cls_api.c
> @@ -2952,6 +2952,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net,
> return PTR_ERR(ops);
> if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {
> NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier");
> + module_put(ops->owner);
> return -EOPNOTSUPP;
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add()
2023-06-07 2:23 [PATCH net v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add() Hangyu Hua
2023-06-07 7:15 ` Larysa Zaremba
@ 2023-06-07 11:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-06-07 11:40 UTC (permalink / raw)
To: Hangyu Hua
Cc: jhs, xiyou.wangcong, jiri, davem, edumazet, kuba, pabeni,
simon.horman, larysa.zaremba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 7 Jun 2023 10:23:01 +0800 you wrote:
> try_module_get will be called in tcf_proto_lookup_ops. So module_put needs
> to be called to drop the refcount if ops don't implement the required
> function.
>
> Fixes: 9f407f1768d3 ("net: sched: introduce chain templates")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
>
> [...]
Here is the summary with links:
- [net,v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add()
https://git.kernel.org/netdev/net/c/44f8baaf230c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-07 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 2:23 [PATCH net v2] net: sched: fix possible refcount leak in tc_chain_tmplt_add() Hangyu Hua
2023-06-07 7:15 ` Larysa Zaremba
2023-06-07 11:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox