From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened
Date: Wed, 7 Jun 2023 12:01:11 -0400 [thread overview]
Message-ID: <ZICpyBl9/Beq46ad@itl-email> (raw)
In-Reply-To: <ZIA1yLiJyfcJ45vD@infradead.org>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On Wed, Jun 07, 2023 at 12:46:16AM -0700, Christoph Hellwig wrote:
> > --- a/drivers/block/xen-blkback/xenbus.c
> > +++ b/drivers/block/xen-blkback/xenbus.c
> > @@ -3,6 +3,20 @@
> > Copyright (C) 2005 Rusty Russell <rusty@rustcorp.com.au>
> > Copyright (C) 2005 XenSource Ltd
> >
> > +In addition to the Xenstore nodes required by the Xen block device
> > +specification, this implementation of blkback uses a new Xenstore
> > +node: "opened". blkback sets "opened" to "0" before the hotplug script
> > +is called. Once the device node has been opened, blkback sets "opened"
> > +to "1".
>
> This is a really odd comment style, and a really strange place for it.
> To me it feels like this should just be a file in Documentation as it
> relates to how to use the driver, and doesn't really explain the code.
Will fix in v3.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-07 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 21:48 [PATCH 0/2] xen/blkback: support delete-on-close block devices Demi Marie Obenour
2023-06-01 21:48 ` [PATCH 1/2] xen-blkback: Implement diskseq checks Demi Marie Obenour
2023-06-07 7:44 ` Christoph Hellwig
2023-06-07 16:00 ` Demi Marie Obenour
2023-06-01 21:48 ` [PATCH 2/2] xen-blkback: Inform userspace that device has been opened Demi Marie Obenour
2023-06-07 7:46 ` Christoph Hellwig
2023-06-07 16:01 ` Demi Marie Obenour [this message]
2023-06-06 9:31 ` [PATCH 0/2] xen/blkback: support delete-on-close block devices Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZICpyBl9/Beq46ad@itl-email \
--to=demi@invisiblethingslab.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox