From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3724C7EE2F for ; Wed, 7 Jun 2023 16:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240643AbjFGQBT (ORCPT ); Wed, 7 Jun 2023 12:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239734AbjFGQBR (ORCPT ); Wed, 7 Jun 2023 12:01:17 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1586D1988; Wed, 7 Jun 2023 09:01:17 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 856305C0229; Wed, 7 Jun 2023 12:01:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 07 Jun 2023 12:01:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1686153676; x=1686240076; bh=2UoO8B7Qn0k2QzL7d+OGaqTzOAQvpjpsvVc EYJCpl1o=; b=P/sylwK0Oo2scXna9wnN25CgyGn7pCDm4HvPPp51OQzHyuY1XG+ yLkTAfQZoYJXMxIzSsuzfnGWCr8F/fElncTbLW2wbEK4XTxSdgSbZnhqQWccdP30 3Exd1VvNZr2iXIxUAp5RrlUX/YI6V0erTq6QVQbAMkwNlkg7l2Y/fNMQCcPxBiHA Z553O/RH7ofCxhjZGOaV/I2raxnI2QtDJN7SrjD+ssxFyXWRP3fDShCTeoviSgmj pIeUOHd8RtMXxKoLKMXixeVYS2kerT7qigsYgpWWVEP3yUTPX9/ljHFstEx6DGTq 8X2qvxn1rbw9t+cJ+BXLws7pGe0aPCX8lPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686153676; x=1686240076; bh=2UoO8B7Qn0k2Q zL7d+OGaqTzOAQvpjpsvVcEYJCpl1o=; b=M+SYPvvFAPpg2FqxW2Ocp8tcv/oST 7Xl28iQJ0aAb48lYJanERjkGIkM9A0YzEhJIO9v6fW+Cgp2URoa0x8d0xbGavyR+ 2YaTycU097kwVROrl0P+4Xv5VfX+KjQzryn53sqeNJyLQhHTAV63B35FRDUFQhQm sHqRFCer8HEi330HHhdOU8cye4/t7+kaiL7/as4GQfEA9WaBiRuTE87VcKg8zJXa VVAATsp5Mv3wEhf7v6Q/CSHeiMjU+jIwz8y5m8jrKqui9RmaUOTJ+DWrjmFwXCPh rKWInA60g5hv7g3su31JEKu8s0bk4pjo+FaS9zoMqsKWumXQqUxfZoy5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtgedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepudeileefueetvdelheeuteffjeeg jeegffekleevueelueekjeejudffteejkeetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Jun 2023 12:01:14 -0400 (EDT) Date: Wed, 7 Jun 2023 12:01:11 -0400 From: Demi Marie Obenour To: Christoph Hellwig Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Jens Axboe , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened Message-ID: References: <20230601214823.1701-1-demi@invisiblethingslab.com> <20230601214823.1701-3-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WgIi5Tes309KNxkl" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --WgIi5Tes309KNxkl Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 7 Jun 2023 12:01:11 -0400 From: Demi Marie Obenour To: Christoph Hellwig Cc: Roger Pau =?utf-8?B?TW9ubsOp?= , Jens Axboe , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] xen-blkback: Inform userspace that device has been opened On Wed, Jun 07, 2023 at 12:46:16AM -0700, Christoph Hellwig wrote: > > --- a/drivers/block/xen-blkback/xenbus.c > > +++ b/drivers/block/xen-blkback/xenbus.c > > @@ -3,6 +3,20 @@ > > Copyright (C) 2005 Rusty Russell > > Copyright (C) 2005 XenSource Ltd > > =20 > > +In addition to the Xenstore nodes required by the Xen block device > > +specification, this implementation of blkback uses a new Xenstore > > +node: "opened". blkback sets "opened" to "0" before the hotplug script > > +is called. Once the device node has been opened, blkback sets "opened" > > +to "1". >=20 > This is a really odd comment style, and a really strange place for it. > To me it feels like this should just be a file in Documentation as it > relates to how to use the driver, and doesn't really explain the code. Will fix in v3. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --WgIi5Tes309KNxkl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmSAqckACgkQsoi1X/+c IsGmCg/+PbmcJVAb/MiNuNHzPQ/Vq7YzVW9qFtwIrvQC5Eb7EjXPWQ4P5TRbBdZS tH4aoGHWANtB8/M1Gh8GmtYHttitFzuO7oe22pIisvOAM4+28uvXojLN3v4SjrhE /Dn7xkvivLfKKqmTUbyv5cPbhZVc96VeZ5mn0Gt57+oGMQU+DE4BAG8rRicYW2Ok isEAlvI+V08xKVW0dOYu9Qis/Qm48kQhbCZHWTuXlIrKBgcTYu40LQMrYg9nd8YB 9uQ75fyAiuZMM55fu54spREudNDP1FkFX5uuXj2A1M8Yjl7G93RMaizvUrjPLeUO fKbiWrk8Nlc0OKnS4WOAYtnvsTpH6LaJuZA7/IT5sYG7fXT0B0krVxvZsgInNxKJ nsbr46g4Sv2LoJTifF8rrF+ujGBWceDkB5VIo6bhYqNbJ8xLGfaFEYrF7XcliWf0 RstpIOa7kKVA0GV/l8HezD+Iez1BoUatPsPq1cdzp7bTsN2rgG6VK+0jWmV01n/N 8wyHxfXU8Z3NpTNFPJXgjTu4zqcLsKpmpsbP5Ee7W3bKNrUZXIRL6spGRJcOxcsi POrPJ72Zf8Sw+vULlK0+hKSf3BtckaTVmCU9e3qJE+4ukrzpoFVvf96mPVaXLMaT OLY/3zj/5bNxCzSC+GWKTMTg2lL6Txbyfyht0YkfmUL3Rgh9i9Y= =nc8R -----END PGP SIGNATURE----- --WgIi5Tes309KNxkl--