From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9204BC7EE23 for ; Thu, 8 Jun 2023 17:40:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234282AbjFHRkD (ORCPT ); Thu, 8 Jun 2023 13:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbjFHRkA (ORCPT ); Thu, 8 Jun 2023 13:40:00 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 668A72115 for ; Thu, 8 Jun 2023 10:39:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EF45364FDF for ; Thu, 8 Jun 2023 17:39:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E3B9C433EF; Thu, 8 Jun 2023 17:39:56 +0000 (UTC) Date: Thu, 8 Jun 2023 18:39:53 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, broonie@kernel.org, Will Deacon , Marc Zyngier , Rob Herring , Suzuki K Poulose , James Morse , kvmarm@lists.linux.dev, coresight@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 00/14] arm64/sysreg: Convert TRBE registers to automatic generation Message-ID: References: <20230602062552.565992-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230602062552.565992-1-anshuman.khandual@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Anshuman, On Fri, Jun 02, 2023 at 11:55:38AM +0530, Anshuman Khandual wrote: > Changes in V2: > > - Renamed each individual TRBE register fields as per auto-gen tools > - Converted each individual TRBE registers as per auto-gen tools > - Added new register fields as per DDI0601 2023-03 Mark had some comments about using Enum for some bitfields. While not essential, it would be nice to have those fixed. It's probably easier to do an incremental patch fixing those, so please post one (or repost the whole series, whatever is easier for you). Thanks. -- Catalin