From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A61A8C7EE2E for ; Fri, 9 Jun 2023 08:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240607AbjFIIfy (ORCPT ); Fri, 9 Jun 2023 04:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241232AbjFIIfR (ORCPT ); Fri, 9 Jun 2023 04:35:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FA0D1B9 for ; Fri, 9 Jun 2023 01:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686299667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EknIZyUh7PQqINbfxxOFxOQjWFkQnRhHPN2hFuriDog=; b=JUSn51enxiCrY7E6IBWFzEDgjCAo3fGVq4xUKk4iDnx2/6KLyr6QYtsP9+oPDCL6WI0x3/ 5va9a0rZr4A3o0V5h1Zw/mBg8X/aldm0XlUkNysriXLeGmofw3Fhs5FL2aRPwYMqeeSWyI 5lq4KY7SiININo8jroCs1j8ewhi6IwM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-KaJfyS03M-WHx2lyCun43w-1; Fri, 09 Jun 2023 04:34:22 -0400 X-MC-Unique: KaJfyS03M-WHx2lyCun43w-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BAC91384CC69; Fri, 9 Jun 2023 08:34:21 +0000 (UTC) Received: from localhost (ovpn-12-92.pek2.redhat.com [10.72.12.92]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 48F8C515540; Fri, 9 Jun 2023 08:34:18 +0000 (UTC) Date: Fri, 9 Jun 2023 16:34:14 +0800 From: Baoquan He To: John Paul Adrian Glaubitz Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@lst.de, rppt@kernel.org, willy@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, deller@gmx.de, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org Subject: Re: [PATCH v6 11/19] sh: add including Message-ID: References: <20230609075528.9390-1-bhe@redhat.com> <20230609075528.9390-12-bhe@redhat.com> <025fe4853ff0a258dafdf71075419a2b740cabbd.camel@physik.fu-berlin.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <025fe4853ff0a258dafdf71075419a2b740cabbd.camel@physik.fu-berlin.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/09/23 at 10:10am, John Paul Adrian Glaubitz wrote: > Hello Baoquan! > > On Fri, 2023-06-09 at 15:55 +0800, Baoquan He wrote: > > Also add macro definitions for port|mm io functions since SuperH > > has its own implementation in arch/sh/kernel/iomap.c and > > arch/sh/include/asm/io_noioport.h. These will conflict with the port|mm io > > function definitions in include/asm-generic/io.h to cause compiling > > errors like below: > > What change does the "Also" refer to? It refers to these kind of macro definitions, this place and those in other several places. Please correct me if I misused the expression to cause confusion. +#define ioread8 ioread8 +#define ioread16 ioread16 +#define ioread16be ioread16be +#define ioread32 ioread32 +#define ioread32be ioread32be + +#define iowrite8 iowrite8 +#define iowrite16 iowrite16 +#define iowrite16be iowrite16be +#define iowrite32 iowrite32 +#define iowrite32be iowrite32be + +#define ioread8_rep ioread8_rep +#define ioread16_rep ioread16_rep +#define ioread32_rep ioread32_rep + +#define iowrite8_rep iowrite8_rep +#define iowrite16_rep iowrite16_rep +#define iowrite32_rep iowrite32_rep