Re: [PATCH v7 08/21] workqueue: Use global variant for add_timer()

Frederic Weisbecker
2023-06-05T22:25:41Z

Le Wed, May 24, 2023 at 09:06:16AM +0200, Anna-Maria Behnsen a écrit :
> The implementation of the NOHZ pull at expiry model will change the timer
> bases per CPU. Timers, that have to expire on a specific CPU, require the
> TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be
> dropped. This is required for call sites which use the timer alternately as
> pinned and not pinned timer like workqueues do.
>
> Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped.
>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
> Acked-by: Tejun Heo <tj@kernel.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Lai Jiangshan <jiangshanlai@gmail.com>

Getting confused between v6 and v7...

Anyway:

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>