From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Jadav, Raag" <raag.jadav@intel.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sangannavar,
Mallikarjunappa" <mallikarjunappa.sangannavar@intel.com>,
"N, Pandith" <pandith.n@intel.com>
Subject: Re: [PATCH v2 1/4] pinctrl: intel: refine set_mux hook
Date: Mon, 12 Jun 2023 18:17:03 +0300 [thread overview]
Message-ID: <ZIc279PMCz/Pn6fU@smile.fi.intel.com> (raw)
In-Reply-To: <DM6PR11MB2779679A4AF6023180B942248C54A@DM6PR11MB2779.namprd11.prod.outlook.com>
On Mon, Jun 12, 2023 at 07:15:59AM +0000, Jadav, Raag wrote:
> > On Fri, Jun 09, 2023 at 01:55:36PM +0530, Raag Jadav wrote:
> > > Utilize a temporary variable for common shift operation inside
> > > ->set_mux() hook and improve readability.
> >
> > Seems the bloat-o-meter statistics is missing here.
>
> I changed the commit message as pointed out by Mika in v1.
> Do I change it back?
No back, only forward!
I.e. you need to update Subject to follow the pattern, ->set_mux()
in this case) and add a note that the change makes code smaller.
It will be two selling points.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-12 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:25 [PATCH v2 0/4] Minor improvements for Intel pinctrl Raag Jadav
2023-06-09 8:25 ` [PATCH v2 1/4] pinctrl: intel: refine set_mux hook Raag Jadav
2023-06-09 16:41 ` Andy Shevchenko
2023-06-12 7:15 ` Jadav, Raag
2023-06-12 15:17 ` Andy Shevchenko [this message]
2023-06-09 8:25 ` [PATCH v2 2/4] pinctrl: intel: refine irq_set_type hook Raag Jadav
2023-06-09 8:25 ` [PATCH v2 3/4] pinctrl: intel: simplify exit path of set_mux hook Raag Jadav
2023-06-09 8:35 ` Mika Westerberg
2023-06-09 9:10 ` Jadav, Raag
2023-06-09 9:29 ` Mika Westerberg
2023-06-09 8:25 ` [PATCH v2 4/4] pinctrl: intel: simplify exit path of gpio_request_enable hook Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIc279PMCz/Pn6fU@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pandith.n@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox