From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Hans de Goede <hdegoede@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
Lee Jones <lee@kernel.org>, Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v3 0/4] Make sscanf() stricter
Date: Mon, 12 Jun 2023 16:25:01 -0400 [thread overview]
Message-ID: <ZId/IA41c2sJyvE0@itl-email> (raw)
In-Reply-To: <6ab6adce-2318-4ae6-bde6-4317485639fd@p183>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
On Mon, Jun 12, 2023 at 02:59:38PM +0300, Alexey Dobriyan wrote:
> > + bool _placeholder;
> > + return simple_strntoull(cp, INT_MAX, endp, base, &_placeholder);
>
> This can be done without introducing dummy variables:
>
> void f(bool *b)
> {
> }
>
> f((bool[1]){});
This is more consise, but (at least to me) significantly less readable.
> > > lib/vsprintf.c:3727:26: error: unknown conversion type character ‘!’ in format [-Werror=format=]
> > So NAK.
>
> Yeah, ! should go after format specifier like it does for %p.
I hadn't considered that. Is the typical approach in Linux to use e.g.
%d%[!] if one wants a literal '!'?
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-12 20:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 11:59 [PATCH v3 0/4] Make sscanf() stricter Alexey Dobriyan
2023-06-12 20:25 ` Demi Marie Obenour [this message]
2023-06-12 21:00 ` Andy Shevchenko
2023-06-12 21:23 ` Demi Marie Obenour
2023-06-12 22:16 ` Andy Shevchenko
2023-06-13 13:02 ` David Laight
2023-06-13 15:35 ` Demi Marie Obenour
2023-06-14 8:23 ` David Laight
2023-06-14 20:08 ` Demi Marie Obenour
2023-06-15 8:06 ` David Laight
2023-06-15 11:23 ` Andy Shevchenko
2023-06-15 11:38 ` David Laight
2023-06-20 13:34 ` Petr Mladek
2023-06-20 13:52 ` Andy Shevchenko
2023-06-20 13:54 ` Andy Shevchenko
2023-06-20 14:57 ` Petr Mladek
2023-06-20 15:05 ` Andy Shevchenko
2023-06-21 0:56 ` Demi Marie Obenour
-- strict thread matches above, loose matches on Subject: below --
2023-06-10 20:40 Demi Marie Obenour
2023-06-12 15:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZId/IA41c2sJyvE0@itl-email \
--to=demi@invisiblethingslab.com \
--cc=adobriyan@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jgross@suse.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@kernel.org \
--cc=mchehab@kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=senozhatsky@chromium.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox