Re: [PATCH v3 0/4] Make sscanf() stricter

Demi Marie Obenour
2023-06-12T20:25:26Z

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

On Mon, Jun 12, 2023 at 02:59:38PM +0300, Alexey Dobriyan wrote:
> > + bool _placeholder;
> > + return simple_strntoull(cp, INT_MAX, endp, base, &_placeholder);
>
> This can be done without introducing dummy variables:
>
> void f(bool *b)
> {
> }
>
> f((bool[1]){});

This is more consise, but (at least to me) significantly less readable.

> > > lib/vsprintf.c:3727:26: error: unknown conversion type character ‘!’ in format [-Werror=format=]
> > So NAK.
>
> Yeah, ! should go after format specifier like it does for %p.

I hadn't considered that. Is the typical approach in Linux to use e.g.
%d%[!] if one wants a literal '!'?
--
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]