public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ipv6: clean up some inconsistent indenting
@ 2023-06-14  1:49 Jiapeng Chong
  2023-06-14 13:22 ` Simon Horman
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-06-14  1:49 UTC (permalink / raw)
  To: davem
  Cc: dsahern, edumazet, kuba, pabeni, netdev, linux-kernel,
	Jiapeng Chong, Abaci Robot

No functional modification involved.

net/ipv6/ip6_offload.c:252 ipv6_gro_receive() warn: inconsistent indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5522
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 net/ipv6/ip6_offload.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index d6314287338d..6c924ba10821 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -249,10 +249,10 @@ INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head *head,
 		 * (nlen != (sizeof(*iph2) + ipv6_exthdrs_len(iph2, &ops)))
 		 * memcmp() alone below is sufficient, right?
 		 */
-		 if ((first_word & htonl(0xF00FFFFF)) ||
-		     !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
-		     !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
-		     iph->nexthdr != iph2->nexthdr) {
+		if ((first_word & htonl(0xF00FFFFF)) ||
+		    !ipv6_addr_equal(&iph->saddr, &iph2->saddr) ||
+		    !ipv6_addr_equal(&iph->daddr, &iph2->daddr) ||
+		    iph->nexthdr != iph2->nexthdr) {
 not_same_flow:
 			NAPI_GRO_CB(p)->same_flow = 0;
 			continue;
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ipv6: clean up some inconsistent indenting
  2023-06-14  1:49 [PATCH] ipv6: clean up some inconsistent indenting Jiapeng Chong
@ 2023-06-14 13:22 ` Simon Horman
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2023-06-14 13:22 UTC (permalink / raw)
  To: Jiapeng Chong
  Cc: davem, dsahern, edumazet, kuba, pabeni, netdev, linux-kernel,
	Abaci Robot

On Wed, Jun 14, 2023 at 09:49:59AM +0800, Jiapeng Chong wrote:
> No functional modification involved.
> 
> net/ipv6/ip6_offload.c:252 ipv6_gro_receive() warn: inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5522
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Hi Jiapeng,

unfortunately we don't accept patches that only clean
up code for checkpatch warnings (or similar) for
Networking code.

-- 
pw-bot: reject

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-06-14 13:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-14  1:49 [PATCH] ipv6: clean up some inconsistent indenting Jiapeng Chong
2023-06-14 13:22 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox