From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: hexingwei001@208suo.com, pmladek@suse.com,
senozhatsky@chromium.org, linux-kernel@vger.kernel.org,
linux@rasmusvillemoes.dk
Subject: Re: [PATCH] lib/test_printf.c: space required after that ','
Date: Wed, 14 Jun 2023 18:16:36 +0300 [thread overview]
Message-ID: <ZInZ1BcHHQbok+wg@smile.fi.intel.com> (raw)
In-Reply-To: <20230614110640.57817123@gandalf.local.home>
On Wed, Jun 14, 2023 at 11:06:40AM -0400, Steven Rostedt wrote:
> On Wed, 14 Jun 2023 15:32:30 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Jun 14, 2023 at 04:30:55PM +0800, hexingwei001@208suo.com wrote:
> > > Add missing spaces to clear checkpatch errors:
> > >
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> > > lib/test_printf.c:562: ERROR: space required after that ',' (ctx:VxV).
> >
> > Doesn't make any difference to the code, so let do this (unneeded) churn
> > to calm checkpatch down.
> >
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> checkpatch is for patches (new code) and should not be run on existing code.
Why does it have -f option? What do you propose to prevent people from using it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-14 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230614082523.63191-1-panzhiai@cdjrlc.com>
2023-06-14 8:30 ` [PATCH] lib/test_printf.c: space required after that ',' hexingwei001
2023-06-14 12:32 ` Andy Shevchenko
2023-06-14 15:06 ` Steven Rostedt
2023-06-14 15:16 ` Andy Shevchenko [this message]
2023-06-18 3:55 ` Sergey Senozhatsky
2023-06-19 6:45 ` Pavel Machek
2023-06-19 13:20 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZInZ1BcHHQbok+wg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hexingwei001@208suo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox