From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BF1EB64DB for ; Wed, 14 Jun 2023 16:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231942AbjFNQLF (ORCPT ); Wed, 14 Jun 2023 12:11:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbjFNQLB (ORCPT ); Wed, 14 Jun 2023 12:11:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E68E1FCC for ; Wed, 14 Jun 2023 09:11:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEA6163D68 for ; Wed, 14 Jun 2023 16:11:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CC53C433C8; Wed, 14 Jun 2023 16:11:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686759060; bh=d/6LGrrxRVt13rFpG8sOHqoRpWYJK2jysFBzCM0AugY=; h=Date:From:To:Subject:References:In-Reply-To:From; b=MzkPzC/V9icUPyqtNTVo2NcGiI4XiCHiI73DmrSR/HEqVlU/Fl+ZMfB3UxoSC/l+M Q3j21Qs7GmEaswumMO6lbsSSYUKgliMlgnL07FSpta/wHiRMsaJ+9wCukkhMuX7e2c dATG59SwQ8q1sBqu2yPk7uRrhGYThcqbONY6xB4JBl3RxmvR/vx0ergpV1n2zcNZo7 UCBwPL0ecAzCIQbq8Vad1WWe39J0B4R0ZBrmNBV0YC6eIl70XD4X2wduteYeFW1oob ma+HHvIm19Z1jwxSm4XCSGoVmY5UKV/pbbikug8tvVFH0RJXrYrL5QHQhoipM5WWOH pEkH08tA0fHKg== Date: Wed, 14 Jun 2023 09:10:58 -0700 From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2] f2fs: do not issue small discard commands during checkpoint Message-ID: References: <20230613203947.2745943-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230613203947.2745943-1-jaegeuk@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If there're huge # of small discards, this will increase checkpoint latency insanely. Let's issue small discards only by trim. Signed-off-by: Jaegeuk Kim --- Change log from v1: - move the skip logic to avoid dangling objects fs/f2fs/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 8c7af8b4fc47..0457d620011f 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -2193,7 +2193,7 @@ void f2fs_clear_prefree_segments(struct f2fs_sb_info *sbi, len = next_pos - cur_pos; if (f2fs_sb_has_blkzoned(sbi) || - (force && len < cpc->trim_minlen)) + !force || len < cpc->trim_minlen) goto skip; f2fs_issue_discard(sbi, entry->start_blkaddr + cur_pos, -- 2.41.0.162.gfafddb0af9-goog