From: Simon Horman <simon.horman@corigine.com>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 0/3] net: stmmac: fix & improve driver statistics
Date: Wed, 14 Jun 2023 21:39:17 +0200 [thread overview]
Message-ID: <ZIoXZQXLTWKF8nCZ@corigine.com> (raw)
In-Reply-To: <20230614161847.4071-1-jszhang@kernel.org>
On Thu, Jun 15, 2023 at 12:18:44AM +0800, Jisheng Zhang wrote:
> patch1 and patch2 fix two issues in net driver statistics:
> 1. network driver statistics are cleared in .ndo_close() and
> .ndo_open() cycle
> 2. some network driver statistics overflow on 32 bit platforms
I would encourage you to describe these as enhancements or similar,
but not fixes. Because fix implies a bug, such as a crash. And
bugs for fixes are handled by a slightly different process which
often includes backporting.
> patch3 use pcpu statistics where necessary to remove frequent
> cacheline ping pongs.
Assuming these are three enhancements, then they should be
targeted at the net-next tree. And that should be noted in the subject:
Subject: [PATCH net-next v2] ...
Unfortunately the series does not seem to apply to net-next
in its current form. So it probably needs to be rebased and reposted.
If you do post an updated series, please observe a 24h grace
period between postings, to give reviewers time to do their thing.
Link: https://docs.kernel.org/process/maintainer-netdev.html
next prev parent reply other threads:[~2023-06-14 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 16:18 [PATCH 0/3] net: stmmac: fix & improve driver statistics Jisheng Zhang
2023-06-14 16:18 ` [PATCH 1/3] net: stmmac: don't clear network statistics in .ndo_open() Jisheng Zhang
2023-06-14 16:18 ` [PATCH 2/3] net: stmmac: fix overflow of some network statistics Jisheng Zhang
2023-06-14 16:18 ` [PATCH 3/3] net: stmmac: use pcpu statistics where necessary Jisheng Zhang
2023-06-14 18:38 ` kernel test robot
2023-06-14 22:16 ` kernel test robot
2023-06-15 4:07 ` kernel test robot
2023-06-14 19:39 ` Simon Horman [this message]
2023-06-15 15:17 ` [PATCH 0/3] net: stmmac: fix & improve driver statistics Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIoXZQXLTWKF8nCZ@corigine.com \
--to=simon.horman@corigine.com \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jernej.skrabec@gmail.com \
--cc=joabreu@synopsys.com \
--cc=jszhang@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox