From: Simon Horman <simon.horman@corigine.com>
To: Wang Ming <machel@vivo.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops
Date: Thu, 15 Jun 2023 15:03:15 +0200 [thread overview]
Message-ID: <ZIsME1gwEWEyyN1o@corigine.com> (raw)
In-Reply-To: <20230615070512.6634-1-machel@vivo.com>
On Thu, Jun 15, 2023 at 03:04:58PM +0800, Wang Ming wrote:
> The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should
> have fwnode_handle_put() before return which could avoid resource leaks.
> This patch could fix this bug.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
Hi Wang Ming,
unfortunately your patch has been whitespace mangled - tabs have been
converted into 8 spaces. Possibly this was done by your mail client
or mail server. In any case the result is that the patch doesn't apply.
And unfortunately that breaks our processes.
Also, I'm assuming that as this patch is a fix, it is targeted at the
"net", as opposed to "net-next", tree. This should be noted in the subject.
Subject: [PATCH net v2] ...
Lastly, looking at the git history of qca8k-leds.c, I think that
a better prefix for the patch is "net: dsa: qca8k: ".
Subject: [PATCH net v2] net: dsa: qca8k: ...
Please consider addressing the problems and reposting your patch.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-06-15 13:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 7:04 [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops Wang Ming
2023-06-15 13:03 ` Simon Horman [this message]
2023-06-15 20:36 ` Vladimir Oltean
[not found] ` <PS1PR0601MB3737C84D2AF397AB8B4E9207BD58A@PS1PR0601MB3737.apcprd06.prod.outlook.com>
2023-06-16 8:58 ` 回复: " Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsME1gwEWEyyN1o@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox