From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0695EB64DB for ; Thu, 15 Jun 2023 15:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240831AbjFOPm1 (ORCPT ); Thu, 15 Jun 2023 11:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238814AbjFOPmZ (ORCPT ); Thu, 15 Jun 2023 11:42:25 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 712F6123; Thu, 15 Jun 2023 08:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686843744; x=1718379744; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1esU+W96PtNXw+8kc/bDUrIBmwX+Wv8g4LjSnrvzNiM=; b=DAtiTbCdFcr3Ha5tFNevmMnMClwecDlZciBepv2eEKubO6Ec2T6+4uzp c/6TIqxMXFwtrxZdJzdoJzhmnDdhlZl4nxabE5+L13j+kscwmumWF3ST1 su2PNmpEhna/CX3ebYiJH9nWwwWkldwWfUOsQicy9M4DFmSZ4DgYHBI+Z d0g37ZQ2nw9mgUjgR4w3vdtqp4fd4g1kNP8G7Wj93aex9goaVlYQyinm1 w0vZ5Swbn+cgPOCqtIvdjEdyhnGsN1GKcYlZW9WVzaKW8ufy1ke+NidVS LlQ5SbLJ7LtKeUVFJQyvVgV9V4YF3ffJK5aHecFapyDy3/X60q4WIeBwI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="361456083" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="361456083" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 08:28:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="959247177" X-IronPort-AV: E=Sophos;i="6.00,245,1681196400"; d="scan'208";a="959247177" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga006.fm.intel.com with ESMTP; 15 Jun 2023 08:28:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1q9otl-003yOe-0z; Thu, 15 Jun 2023 18:28:33 +0300 Date: Thu, 15 Jun 2023 18:28:33 +0300 From: Andy Shevchenko To: Raag Jadav Cc: linus.walleij@linaro.org, mika.westerberg@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com Subject: Re: [PATCH v4] pinctrl: intel: refine ->irq_set_type() hook Message-ID: References: <20230615125022.27421-1-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230615125022.27421-1-raag.jadav@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 06:20:22PM +0530, Raag Jadav wrote: > Refine ->irq_set_type() hook and improve its readability by: > > - Reducing scope of spinlock by moving unneeded operations out of it. > - Dropping redundant PADCFG0_RXEVCFG_SHIFT and including it directly > into PADCFG0_RXEVCFG_* definitions. > - Utilizing temporary variables for common operations. > - Simplifying if-else-if chain. Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko