From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v3 3/5] gpio: aggregator: Prevent collisions between DT and user device IDs
Date: Thu, 15 Jun 2023 18:36:07 +0300 [thread overview]
Message-ID: <ZIsv51766AXAiQ7E@smile.fi.intel.com> (raw)
In-Reply-To: <CAMuHMdVAwKCUnOeuz_PE6ijtfTVf8a3rTQZ=JvThOmqytu5HCA@mail.gmail.com>
On Thu, Jun 15, 2023 at 04:54:14PM +0200, Geert Uytterhoeven wrote:
> On Thu, Jun 15, 2023 at 3:51 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > In case we have a device instantiated via DT or other means than
> > via new_device sysfs node, the collision with the latter is possible.
> > Prevent such collisions by allocating user instantiated devices with
> > higher IDs, currently set to 1024.
>
> Can you please elaborate? How exactly is this possible?
>
> Aggregators instantiated through sysfs are named "gpio-aggregator.<n>",
> and are IDR-based.
> Aggregators instantiated from DT are named "<unit-address>.<node-name>".
> How can this conflict? When instantiated from ACPI?
> What am I missing?
Nothing. It's me who misunderstood how OF platform device naming schema works.
So this patch can be discarded as we never will have gpio-delay available for
removal via delete_device sysfs node.
Bart, tell me if you need a new version w/o this patch (but note that b4 can
handle this case with
b4 -slt -P1,2,4,5 ...
).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-15 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 13:20 [PATCH v3 0/5] gpio: aggregator: Incorporate gpio-delay functionality Andy Shevchenko
2023-06-15 13:20 ` [PATCH v3 1/5] gpio: aggregator: Remove CONFIG_OF and of_match_ptr() protections Andy Shevchenko
2023-06-15 13:20 ` [PATCH v3 2/5] gpio: aggregator: Support delay for setting up individual GPIOs Andy Shevchenko
2023-06-15 13:20 ` [PATCH v3 3/5] gpio: aggregator: Prevent collisions between DT and user device IDs Andy Shevchenko
2023-06-15 14:54 ` Geert Uytterhoeven
2023-06-15 15:36 ` Andy Shevchenko [this message]
2023-06-15 13:20 ` [PATCH v3 4/5] gpio: aggregator: Set up a parser of delay line parameters Andy Shevchenko
2023-06-15 13:20 ` [PATCH v3 5/5] gpio: delay: Remove duplicative functionality Andy Shevchenko
2023-06-16 9:00 ` [PATCH v3 0/5] gpio: aggregator: Incorporate gpio-delay functionality Bartosz Golaszewski
2023-06-16 9:01 ` Alexander Stein
2023-06-16 13:33 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIsv51766AXAiQ7E@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=geert@linux-m68k.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox