Re: [PATCH v1 1/1] i2c: scmi: Convert to be a platform driver

andriy.shevchenko
2023-06-15T15:52:50Z

On Mon, May 15, 2023 at 07:51:55AM +0000, Michael Brunner wrote:
> On Thu, 2022-09-08 at 13:02 +0300, Andy Shevchenko wrote:
> > On Thu, Sep 08, 2022 at 09:48:29AM +0200, Josef Johansson wrote:
> > > On 9/8/22 08:07, Josef Johansson wrote:
> > > > On 9/7/22 21:47, Wolfram Sang wrote:
> > > > > On Tue, Sep 06, 2022 at 06:55:07PM +0300, Andy Shevchenko
> > > > > wrote:

First of all, sorry for so-o lo-o-ong delay. Too many emails in a backlog.

...

> > > I compiled with linux-6.0.0-rc4 with your patch on top.
> > >
> > > Have been running flawless so far. Boot showed no problems.

> We just noticed that this change prevents the usage of the i2c-scmi
> driver on basically all Kontron COMe based boards.

Does this device have resources defined in DSDT? Can you show all variants?

> The reason is the patch "ACPI / platform: Add SMB0001 HID to
> forbidden_id_list" submitted in November 2018 by Hans de Goede.

> The
> patch blacklists the SMB0001 HID that is also used by the COMe boards.
> This was due to issues with HP AMD based laptops according to the
> commit message.
> Ironically the commit message there states that it is OK to blacklist
> the HID as the device directly binds to the acpi_bus and therefore the
> platform_device is not needed anyway. This changed with this patch.
>
> As this affects all systems using this HID, applying a patch that
> whitelists specific boards again in the acpi-platform driver doesn't
> seem to be a good solution to me.
> Therefore I would request to remove this patch again, unless someone
> has a better idea.

I have a better idea if the DSDT has no resources. See the Q above.

--
With Best Regards,
Andy Shevchenko