From: Johan Hovold <johan@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Maximilian Luz <luzmaximilian@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Ard Biesheuvel <ardb@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Sumit Garg <sumit.garg@linaro.org>,
Steev Klimaszewski <steev@kali.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] firmware: Add support for Qualcomm UEFI Secure Application
Date: Thu, 29 Jun 2023 14:26:19 +0200 [thread overview]
Message-ID: <ZJ14a5SNS8L3XyFb@hovoldconsulting.com> (raw)
In-Reply-To: <2eb4abde-579f-94ef-b6c3-81ef197329d0@linaro.org>
On Tue, Mar 07, 2023 at 05:51:35PM +0200, Dmitry Baryshkov wrote:
> On 05/03/2023 04:21, Maximilian Luz wrote:
> > +static struct qcuefi_client *qcuefi_acquire(void)
>
> Doesn't this need the __locks annotation?
No, the mutex implementation does not use sparse annotation so adding
__acquires() here will instead introduce new warnings.
> > +{
> > + mutex_lock(&__qcuefi_lock);
> > + return __qcuefi;
> > +}
Johan
prev parent reply other threads:[~2023-06-29 12:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 2:21 [PATCH v3 0/4] firmware: Add support for Qualcomm UEFI Secure Application Maximilian Luz
2023-03-05 2:21 ` [PATCH v3 1/4] firmware: qcom_scm: Export SCM call functions Maximilian Luz
2023-03-07 15:23 ` Dmitry Baryshkov
2023-03-08 12:53 ` Srinivas Kandagatla
2023-03-08 13:48 ` Maximilian Luz
2023-03-08 14:20 ` Srinivas Kandagatla
2023-03-08 15:09 ` Maximilian Luz
2023-03-08 13:29 ` Maximilian Luz
2023-03-05 2:21 ` [PATCH v3 2/4] firmware: Add support for Qualcomm Secure Execution Environment SCM interface Maximilian Luz
2023-03-07 15:32 ` Dmitry Baryshkov
2023-03-08 13:59 ` Maximilian Luz
2023-03-09 8:45 ` Dmitry Baryshkov
2023-03-09 20:54 ` Maximilian Luz
2023-03-07 15:36 ` Dmitry Baryshkov
2023-03-08 14:06 ` Maximilian Luz
2023-03-09 8:07 ` Dmitry Baryshkov
2023-03-05 2:21 ` [PATCH v3 3/4] dt-bindings: firmware: Add Qualcomm QSEECOM interface Maximilian Luz
2023-03-08 22:16 ` Rob Herring
2023-03-08 22:44 ` Maximilian Luz
2023-03-09 1:33 ` Dmitry Baryshkov
2023-03-09 2:27 ` Maximilian Luz
2023-03-09 8:19 ` Dmitry Baryshkov
2023-03-09 20:34 ` Maximilian Luz
2023-03-09 20:43 ` Dmitry Baryshkov
2023-05-02 8:38 ` Sudeep Holla
2023-05-02 10:52 ` Maximilian Luz
2023-05-02 8:31 ` Krzysztof Kozlowski
2023-05-02 10:57 ` Maximilian Luz
2023-03-05 2:21 ` [PATCH v3 4/4] firmware: Add support for Qualcomm UEFI Secure Application Maximilian Luz
2023-03-07 15:51 ` Dmitry Baryshkov
2023-03-08 15:02 ` Maximilian Luz
2023-03-09 8:36 ` Dmitry Baryshkov
2023-03-09 20:44 ` Maximilian Luz
2023-06-29 12:26 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ14a5SNS8L3XyFb@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ardb@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=ilias.apalodimas@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=steev@kali.org \
--cc=sudeep.holla@arm.com \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox