From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68F7EB64DC for ; Thu, 29 Jun 2023 09:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231245AbjF2JaV (ORCPT ); Thu, 29 Jun 2023 05:30:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232063AbjF2J3q (ORCPT ); Thu, 29 Jun 2023 05:29:46 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1805C3ABF; Thu, 29 Jun 2023 02:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688030939; x=1719566939; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=AZfC0g5llZa4NrEUlDxx41BmIYHtzoyZPpjBjZ+qS+Y=; b=VJ5luudV4HUi5OFLyQRCkxvLiAPNWoE5usUSHSEkG8cAjWjUvFhYrpEf 0Y8s2NQpV+mFzvIwN8guPw9RZwAYYZ7o0y++8tj6D8LcwpPePnwDN/R1n G2yP5yV1z3a3v7NR4isyauB4DD0Ou3O2/SBVGap6vCyjRK6p3ZSLbwDMA p397M2LPxyJ8sHB7UxTb1YBQEnVmojScYjSwXwtpYYY2Z9b3RJ0el5pZx 0stVUxrt9zlBeqc3zvuhlefrOrg5+B5ZXT5fIoLkxTn2cjnbURhmWVf1H ph0QybbKFv0vT4eNQG/byu2gPKNOLHlGZy/+3jajaEitIx1/NoMTSvFhN g==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="360914148" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="360914148" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 02:28:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="782623194" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="782623194" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 29 Jun 2023 02:28:56 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qEnxO-000oTx-1B; Thu, 29 Jun 2023 12:28:54 +0300 Date: Thu, 29 Jun 2023 12:28:54 +0300 From: Andy Shevchenko To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen Subject: Re: [RFC PATCH 7/8] ASoC: Intel: Skylake: Update PCI ID list Message-ID: References: <20230628205135.517241-1-amadeuszx.slawinski@linux.intel.com> <20230628205135.517241-8-amadeuszx.slawinski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 29, 2023 at 10:19:06AM +0200, Amadeusz Sławiński wrote: > On 6/28/2023 4:52 PM, Andy Shevchenko wrote: > > On Wed, Jun 28, 2023 at 10:51:34PM +0200, Amadeusz Sławiński wrote: ... > > > + { PCI_DEVICE_DATA(INTEL, HDA_SKL_LP, &snd_soc_acpi_intel_skl_machines) }, > > > > Do you really need TAB(s) in the parameter list? > > I did this to align entries, I know it is not that visible in this patch, > but they are defined close to each other and I feel that it looks better if > they are aligned, but can drop alignment if you prefer. Should I also drop > them in other patches, as I don't see comment for that? I think we may survive without TABs, but the maintainers may have the last word on this. -- With Best Regards, Andy Shevchenko