From: Simon Horman <simon.horman@corigine.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH v1 1/1] netlink: Don't use int as bool in netlink_update_socket_mc()
Date: Thu, 29 Jun 2023 21:24:27 +0200 [thread overview]
Message-ID: <ZJ3aa4jfxoWBc6Q0@corigine.com> (raw)
In-Reply-To: <ZJ3Ttq/zRRKSVyDp@smile.fi.intel.com>
On Thu, Jun 29, 2023 at 09:55:50PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 29, 2023 at 05:11:23PM +0200, Simon Horman wrote:
> > On Thu, Jun 29, 2023 at 04:31:31PM +0300, Andy Shevchenko wrote:
>
> > > - int old, new = !!is_new, subscriptions;
> > > + int subscriptions;
> > > + bool old;
> > >
> > > old = test_bit(group - 1, nlk->groups);
> > > subscriptions = nlk->subscriptions - old + new;
> >
> > Hi Andy,
> >
> > Doing arithmetic with boolean values doesn't seem right to me.
>
> In any case it does not change the status quo, the same still applies to
> the existing code (that's implied in the commit message). And obfuscating
> it for the sake of purity seems wrong to me. Hence this patch.
Yes, sure. That is true.
> > In any case, net-next is closed.
> > Please consider reposting once it re-opens, after 10th July.
>
> Sure.
>
> Thank you for the review!
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
>
prev parent reply other threads:[~2023-06-29 19:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 13:31 [PATCH v1 1/1] netlink: Don't use int as bool in netlink_update_socket_mc() Andy Shevchenko
2023-06-29 15:11 ` Simon Horman
2023-06-29 18:55 ` Andy Shevchenko
2023-06-29 19:24 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ3aa4jfxoWBc6Q0@corigine.com \
--to=simon.horman@corigine.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox