Re: [PATCH v3 1/4] firmware: arm_scmi: Add optional flags to extended names helper

Cristian Marussi
2023-06-30T11:34:09Z

On Tue, Jun 06, 2023 at 04:22:27PM +0000, Oleksii Moisieiev wrote:
> Some recently added SCMI protocols needs an additional flags parameter to
> be able to properly configure the command used to query the extended name
> of a resource.
>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

Hi,

This patch was originally at:

https://lore.kernel.org/linux-arm-kernel/20230505201440.3196734-1-cristian.marussi@arm.com/

but after applying your series with B4 I can see this patch with you as
Author and me as Signer :P ... not sure what has gone wrong but, in general
you should not change Authorship of a someone else patch that you picked in
your series unless you compeletely reworked it; if you changed it slighlty
you should note your changes near your Signed-Off, which is, indeed the other
thing missing here: if you post someone else patch you should add your
Signed-Off too as last.

An example of this in this commit: 7885281260f9b952dc66b67182a2218b01e7859f

Now, I really dont care about Authorship here (but note this also meant Andy
shouted at you instead of me .. :P), but the Signed-Off and Author
mismatch has to be fixed at least, like it is now wont be accepted for sure.

Maybe the missing part is in your mail-client not prepending the From:
line when the sending other people pacthes....git send-email does it
automatically I think but others MUAs dont know.

More detail here, in case you have not seen it already:
https://www.kernel.org/doc/html/v4.10/process/email-clients.html

Thanks,
Cristian