From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: You Kangren <youkangren@vivo.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:USB TYPEC PORT CONTROLLER DRIVERS"
<linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com
Subject: Re: [PATCH] usb: typec: tcpm: Replace the ternary conditional operator with max()
Date: Fri, 30 Jun 2023 15:48:29 +0300 [thread overview]
Message-ID: <ZJ7PHcDXEJHGBwWc@kuha.fi.intel.com> (raw)
In-Reply-To: <20230626121105.3252-1-youkangren@vivo.com>
On Mon, Jun 26, 2023 at 08:11:05PM +0800, You Kangren wrote:
> Replace the ternary conditional operator with max() to make the code clean
>
> Signed-off-by: You Kangren <youkangren@vivo.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 829d75ebab42..2a0b33bd2eb8 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -6353,7 +6353,7 @@ static int tcpm_psy_get_input_power_limit(struct tcpm_port *port,
> src_mv = pdo_fixed_voltage(pdo);
> src_ma = pdo_max_current(pdo);
> tmp = src_mv * src_ma;
> - max_src_uw = tmp > max_src_uw ? tmp : max_src_uw;
> + max_src_uw = max(tmp, max_src_uw);
Is that "tmp" useful anymore - why not drop it while at it?
thanks,
--
heikki
prev parent reply other threads:[~2023-06-30 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 12:11 [PATCH] usb: typec: tcpm: Replace the ternary conditional operator with max() You Kangren
2023-06-30 12:48 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ7PHcDXEJHGBwWc@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=opensource.kernel@vivo.com \
--cc=youkangren@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox