From: Simon Horman <simon.horman@corigine.com>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, sgoutham@marvell.com, lcherian@marvell.com,
gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com
Subject: Re: [net Patch 3/4] octeontx2-af: Add validation before accessing cgx and lmac
Date: Fri, 30 Jun 2023 15:27:32 +0200 [thread overview]
Message-ID: <ZJ7YRP9Fb4HUL1eg@corigine.com> (raw)
In-Reply-To: <20230630062845.26606-4-hkelam@marvell.com>
On Fri, Jun 30, 2023 at 11:58:44AM +0530, Hariprasad Kelam wrote:
> with the addition of new MAC blocks like CN10K RPM and CN10KB
> RPM_USX, LMACs are noncontiguous and CGX blocks are also
> noncontiguous. But during RVU driver initialization, the driver
> is assuming they are contiguous and trying to access
> cgx or lmac with their id which is resulting in kernel panic.
>
> This patch fixes the issue by adding proper checks.
>
> [ 23.219150] pc : cgx_lmac_read+0x38/0x70
> [ 23.219154] lr : rvu_program_channels+0x3f0/0x498
> [ 23.223852] sp : ffff000100d6fc80
> [ 23.227158] x29: ffff000100d6fc80 x28: ffff00010009f880 x27:
> 000000000000005a
> [ 23.234288] x26: ffff000102586768 x25: 0000000000002500 x24:
> fffffffffff0f000
>
> Fixes: 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-06-30 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 6:28 [net Patch 0/4] octeontx2-af: MAC block fixes for CN10KB Hariprasad Kelam
2023-06-30 6:28 ` [net Patch 1/4] octeontx2-af: cn10kb: fix interrupt csr addresses Hariprasad Kelam
2023-06-30 13:26 ` Simon Horman
2023-06-30 6:28 ` [net Patch 2/4] octeontx2-af: Fix mapping for NIX block from CGX connection Hariprasad Kelam
2023-06-30 13:27 ` Simon Horman
2023-06-30 6:28 ` [net Patch 3/4] octeontx2-af: Add validation before accessing cgx and lmac Hariprasad Kelam
2023-06-30 13:27 ` Simon Horman [this message]
2023-06-30 6:28 ` [net Patch 4/4] octeontx2-af: Reset MAC features in FLR Hariprasad Kelam
2023-07-02 14:50 ` [net Patch 0/4] octeontx2-af: MAC block fixes for CN10KB patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJ7YRP9Fb4HUL1eg@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox