From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: linus.walleij@linaro.org, mika.westerberg@linux.intel.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
mallikarjunappa.sangannavar@intel.com, pandith.n@intel.com
Subject: Re: [PATCH v3 3/3] pinctrl: intel: simplify exit path of ->gpio_request_enable() hook
Date: Mon, 19 Jun 2023 16:53:41 +0300 [thread overview]
Message-ID: <ZJBd5RQcvrBib8tq@smile.fi.intel.com> (raw)
In-Reply-To: <20230613085054.10976-4-raag.jadav@intel.com>
On Tue, Jun 13, 2023 at 02:20:54PM +0530, Raag Jadav wrote:
> Simplify exit path of ->gpio_request_enable() hook and save a few bytes.
> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-36 (-36)
> Function old new delta
> intel_gpio_request_enable 186 150 -36
> Total: Before=10453, After=10417, chg -0.34%
While it seems a good footprint improvement, it looks like we do not use goto
in entire drivers/pinctrl/intel. So, I would keep it that way.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-19 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 8:50 [PATCH v3 0/3] Minor improvements for Intel pinctrl Raag Jadav
2023-06-13 8:50 ` [PATCH v3 1/3] pinctrl: intel: refine ->set_mux() hook Raag Jadav
2023-06-14 16:20 ` Andy Shevchenko
2023-06-13 8:50 ` [PATCH v3 2/3] pinctrl: intel: refine ->irq_set_type() hook Raag Jadav
2023-06-14 16:22 ` Andy Shevchenko
2023-06-15 9:48 ` Jadav, Raag
2023-06-15 9:55 ` mika.westerberg
2023-06-15 10:50 ` Andy Shevchenko
2023-06-15 11:08 ` Jadav, Raag
2023-06-15 11:17 ` Andy Shevchenko
2023-06-13 8:50 ` [PATCH v3 3/3] pinctrl: intel: simplify exit path of ->gpio_request_enable() hook Raag Jadav
2023-06-13 15:38 ` Andy Shevchenko
2023-06-19 13:53 ` Andy Shevchenko [this message]
2023-06-14 5:14 ` [PATCH v3 0/3] Minor improvements for Intel pinctrl Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJBd5RQcvrBib8tq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunappa.sangannavar@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pandith.n@intel.com \
--cc=raag.jadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox