Re: [RFC PATCH 2/5] gnss: ubx: use new helper to remove open coded regulator handling

Wolfram Sang
2023-06-20T09:04:33Z

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

> I'm a bit torn about this one as I'm generally sceptical of devres and
> especially helpers that enable or register resources, which just tends to
> lead to subtle bugs.

It is good to think twice with devres, but I also really like this
helper. En-/Disabling the regulator matches the life cycle of the device
itself. The boilerplate code it removes tends also to be error prone.

> Care to respin this one after dropping the merge patch?

Sure, I'll respin this series right away

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]