From: Sasha Levin <sashal@kernel.org>
To: Pavel Machek <pavel@denx.de>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Steve French <stfrench@microsoft.com>,
kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>,
pc@cjr.nz, pc@manguebit.com, ematsumiya@suse.de,
lsahlber@redhat.com, sprasad@microsoft.com, vl@samba.org,
metze@samba.org
Subject: Re: [PATCH AUTOSEL 6.1 07/16] smb3: missing null check in SMB2_change_notify
Date: Tue, 20 Jun 2023 10:44:17 -0400 [thread overview]
Message-ID: <ZJG7QRnLpnA17OVU@sashalap> (raw)
In-Reply-To: <ZIy6cGtTFLZ5emr3@duo.ucw.cz>
On Fri, Jun 16, 2023 at 09:39:28PM +0200, Pavel Machek wrote:
>Hi!
>
>> From: Steve French <stfrench@microsoft.com>
>>
>> [ Upstream commit b535cc796a4b4942cd189652588e8d37c1f5925a ]
>>
>> If plen is null when passed in, we only checked for null
>> in one of the two places where it could be used. Although
>> plen is always valid (not null) for current callers of the
>> SMB2_change_notify function, this change makes it more consistent.
>
>Changelog explains problem can not happen, so... is this important
>enough to backport?
Have you confirmed whether it's indeed the case on all the trees we
support?
--
Thanks,
Sasha
next prev parent reply other threads:[~2023-06-20 14:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-15 11:38 [PATCH AUTOSEL 6.1 01/16] regmap: Account for register length when chunking Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 02/16] iommu/amd: Handle GALog overflows Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 03/16] scsi: target: iscsi: Prevent login threads from racing between each other Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 04/16] HID: google: add jewel USB id Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 05/16] HID: wacom: Add error check to wacom_parse_and_register() Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 06/16] arm64: Add missing Set/Way CMO encodings Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 07/16] smb3: missing null check in SMB2_change_notify Sasha Levin
2023-06-16 19:39 ` Pavel Machek
2023-06-20 14:44 ` Sasha Levin [this message]
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 08/16] media: cec: core: disable adapter in cec_devnode_unregister Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 09/16] media: cec: core: don't set last_initiator if tx in progress Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 10/16] nfcsim.c: Fix error checking for debugfs_create_dir Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 11/16] btrfs: fix an uninitialized variable warning in btrfs_log_inode Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 12/16] usb: gadget: udc: fix NULL dereference in remove() Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 13/16] nvme: double KA polling frequency to avoid KATO with TBKAS on Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 14/16] nvme: check IO start time when deciding to defer KA Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 15/16] ext4: enable the lazy init thread when remounting read/write Sasha Levin
2023-06-15 11:38 ` [PATCH AUTOSEL 6.1 16/16] nvme: improve handling of long keep alives Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJG7QRnLpnA17OVU@sashalap \
--to=sashal@kernel.org \
--cc=ematsumiya@suse.de \
--cc=error27@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lsahlber@redhat.com \
--cc=metze@samba.org \
--cc=pavel@denx.de \
--cc=pc@cjr.nz \
--cc=pc@manguebit.com \
--cc=sprasad@microsoft.com \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
--cc=vl@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox