From: Jason Gunthorpe <jgg@nvidia.com>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] RDMA/cma: Remove NULL check before dev_{put, hold}
Date: Tue, 20 Jun 2023 12:51:21 -0300 [thread overview]
Message-ID: <ZJHK+XVOxRNxpiXm@nvidia.com> (raw)
In-Reply-To: <20230614014328.14007-1-yang.lee@linux.alibaba.com>
On Wed, Jun 14, 2023 at 09:43:28AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning:
>
> ./drivers/infiniband/core/cma.c:4812:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5521
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/infiniband/core/cma.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to for-next, thanks
Jason
next prev parent reply other threads:[~2023-06-20 15:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 1:43 [PATCH -next] RDMA/cma: Remove NULL check before dev_{put, hold} Yang Li
2023-06-20 15:51 ` Jason Gunthorpe [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-31 1:06 Yang Li
2023-04-03 18:24 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJHK+XVOxRNxpiXm@nvidia.com \
--to=jgg@nvidia.com \
--cc=abaci@linux.alibaba.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox