From: Eduardo Valentin <evalenti@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Eduardo Valentin <evalenti@kernel.org>,
eduval@amazon.com, linux-pm@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/7] ythermal: core: report errors to governors
Date: Tue, 20 Jun 2023 21:49:03 -0700 [thread overview]
Message-ID: <ZJKBP3YR63i4otsf@uf8f119305bce5e.ant.amazon.com> (raw)
In-Reply-To: <CAJZ5v0hrddGcoqdT6a0+9t20guW_1cZmbNhP_ZuQTmkCLGSKEA@mail.gmail.com>
On Tue, Jun 20, 2023 at 07:29:57PM +0200, Rafael J. Wysocki wrote:
>
>
>
> On Fri, May 19, 2023 at 5:27 AM Eduardo Valentin <evalenti@kernel.org> wrote:
> >
> > From: Eduardo Valentin <eduval@amazon.com>
> >
> > Currently the thermal governors are not allowed to
> > react on temperature error events as the thermal core
> > skips the handling and logs an error on kernel buffer.
> > This patch adds the opportunity to report the errors
> > when they happen to governors.
> >
> > Now, if a governor wants to react on temperature read
> > errors, they can implement the .check_error() callback.
>
> Explaining the use case for this would help a lot.
Yeah I agree. I also did not send the full series and will also add
the governor changes for this in the next patch series.
The use case here is primarily when temperature reads can fail.
Common use case, not limited to though, is an I2C device temperature sensor.
While it can be, in many cases, reliable, it is not always guaranteed to
have a successful temperature read. In fact, it is common to see a sporadic
temperature read failure, followed by successful reads.
This patch series will enhance the core to allow temperature update
error communication to the governor so the governor can have the
opportunity to act upon sensor failure.
--
All the best,
Eduardo Valentin
next prev parent reply other threads:[~2023-06-21 4:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 3:27 [PATCH 0/7] thermal: enhancements on thermal stats Eduardo Valentin
2023-05-19 3:27 ` [PATCH 1/7] thermal: stats: track time each dev changes due to tz Eduardo Valentin
2023-06-20 13:43 ` Rafael J. Wysocki
2023-06-21 4:37 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 2/7] thermal: stats: track number of change requests " Eduardo Valentin
2023-06-20 17:12 ` Rafael J. Wysocki
2023-06-21 4:40 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 3/7] thermal: stats: introduce thermal zone stats/ directory Eduardo Valentin
2023-05-19 3:27 ` [PATCH 4/7] thermal: stats: introduce thermal zone stats/min_gradient Eduardo Valentin
2023-06-20 17:17 ` Rafael J. Wysocki
2023-05-19 3:27 ` [PATCH 5/7] thermal: stats: introduce tz time in trip Eduardo Valentin
2023-06-20 17:27 ` Rafael J. Wysocki
2023-06-21 4:45 ` Eduardo Valentin
2023-06-23 16:40 ` Rafael J. Wysocki
2023-06-28 20:00 ` Eduardo Valentin
2023-05-19 3:27 ` [PATCH 6/7] ythermal: core: report errors to governors Eduardo Valentin
2023-06-20 17:29 ` Rafael J. Wysocki
2023-06-21 4:49 ` Eduardo Valentin [this message]
2023-05-19 3:27 ` [PATCH 7/7] thermal: stats: add error accounting to thermal zone Eduardo Valentin
2023-06-20 17:32 ` Rafael J. Wysocki
2023-06-21 4:50 ` Eduardo Valentin
2023-05-24 18:22 ` [PATCH 0/7] thermal: enhancements on thermal stats Rafael J. Wysocki
2023-06-05 23:28 ` Eduardo Valentin
2023-06-20 19:05 ` Daniel Lezcano
2023-06-21 4:24 ` Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJKBP3YR63i4otsf@uf8f119305bce5e.ant.amazon.com \
--to=evalenti@kernel.org \
--cc=amitk@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=eduval@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox