From: Vinod Koul <vkoul@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Bard Liao <yung-chuan.liao@linux.intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
bard.liao@intel.com
Subject: Re: [PATCH 3/4] soundwire: extend parameters of new_peripheral_assigned() callback
Date: Wed, 21 Jun 2023 16:29:09 +0530 [thread overview]
Message-ID: <ZJLX/fPM1FbBxM2X@matsya> (raw)
In-Reply-To: <e07d507e-57bf-a2b7-2ab1-f5f45ff5399b@linux.intel.com>
On 08-06-23, 08:24, Pierre-Louis Bossart wrote:
>
> >> -static void generic_new_peripheral_assigned(struct sdw_bus *bus, int dev_num)
> >> +static void generic_new_peripheral_assigned(struct sdw_bus *bus,
> >> + struct sdw_slave *slave,
> >> + int dev_num)
> >> {
> >> struct sdw_cdns *cdns = bus_to_cdns(bus);
> >> struct sdw_intel *sdw = cdns_to_intel(cdns);
> >> diff --git a/include/linux/soundwire/sdw.h b/include/linux/soundwire/sdw.h
> >> index 8a7541ac735e..41a856bedf1e 100644
> >> --- a/include/linux/soundwire/sdw.h
> >> +++ b/include/linux/soundwire/sdw.h
> >> @@ -861,7 +861,9 @@ struct sdw_master_ops {
> >> int (*pre_bank_switch)(struct sdw_bus *bus);
> >> int (*post_bank_switch)(struct sdw_bus *bus);
> >> u32 (*read_ping_status)(struct sdw_bus *bus);
> >> - void (*new_peripheral_assigned)(struct sdw_bus *bus, int dev_num);
> >> + void (*new_peripheral_assigned)(struct sdw_bus *bus,
> >> + struct sdw_slave *slave,
> >
> > maybe better, drop the bus and pass slave (which contains bus)
>
> I kept it for consistency, all callbacks for sdw_master_ops start with
> the bus parameter.
That is a valid point, since this is sdw_master_ops() and not slave,
this looks better
--
~Vinod
next prev parent reply other threads:[~2023-06-21 10:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 3:37 [PATCH 0/4] soundwire: allow for more than 8 devices, keep IDA for wake-capable devices Bard Liao
2023-05-31 3:37 ` [PATCH 1/4] soundwire: add enum to control device number allocation Bard Liao
2023-06-08 7:02 ` Vinod Koul
2023-06-08 13:25 ` Pierre-Louis Bossart
2023-05-31 3:37 ` [PATCH 2/4] soundwire: introduce SDW_DEV_NUM_ALLOC_IDA_WAKE_ONLY Bard Liao
2023-06-08 7:06 ` Vinod Koul
2023-06-08 15:09 ` Pierre-Louis Bossart
2023-06-21 11:00 ` Vinod Koul
2023-06-21 11:28 ` Pierre-Louis Bossart
2023-05-31 3:37 ` [PATCH 3/4] soundwire: extend parameters of new_peripheral_assigned() callback Bard Liao
2023-06-08 7:07 ` Vinod Koul
2023-06-08 13:24 ` Pierre-Louis Bossart
2023-06-21 10:59 ` Vinod Koul [this message]
2023-05-31 3:37 ` [PATCH 4/4] soundwire: intel_auxdevice: use SDW_DEV_NUM_ALLOC_IDA_WAKE_ONLY Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJLX/fPM1FbBxM2X@matsya \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox