public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Marcin Wierzbicki <mawierzb@cisco.com>
Cc: "Kishon Vijay Abraham I" <kishon@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Swapnil Jakhade" <sjakhade@cadence.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
	xe-linux-external@cisco.com, danielwa@cisco.com,
	olicht@cisco.com, "Bartosz Wawrzyniak" <bwawrzyn@cisco.com>
Subject: Re: [PATCH v3] phy: cadence: Sierra: Add single link SGMII register configuration
Date: Wed, 21 Jun 2023 23:21:05 +0530	[thread overview]
Message-ID: <ZJM4iUrlMIVwlfK+@matsya> (raw)
In-Reply-To: <ZJM1uQbXM7rciJ3l@matsya>

On 21-06-23, 23:09, Vinod Koul wrote:
> On 22-05-23, 17:24, Marcin Wierzbicki wrote:
> > Add single link SGMII register configuration for no SSC for
> > cdns,sierra-phy-t0 compatibility string.
> > The configuration is based on Sierra Programmer's Guide and
> > validated in Cisco CrayAR SoC.
> 
> Applied, thanks

This breaks build for me, so dropped. This is with arm64 allmodconfig
and gcc-aarch4 toolchain

drivers/phy/cadence/phy-cadence-sierra.c:2556:32: error: initialized field overwritten [-Werror=override-init]
 2556 |                 [TYPE_SGMII] = {
      |                                ^
drivers/phy/cadence/phy-cadence-sierra.c:2556:32: note: (near initialization for ‘cdns_map_sierra.pma_cmn_vals[3]’)
drivers/phy/cadence/phy-cadence-sierra.c:2599:32: error: initialized field overwritten [-Werror=override-init]
 2599 |                 [TYPE_SGMII] = {
      |                                ^
drivers/phy/cadence/phy-cadence-sierra.c:2599:32: note: (near initialization for ‘cdns_map_sierra.pma_ln_vals[3]’)
cc1: all warnings being treated as errors

-- 
~Vinod

  reply	other threads:[~2023-06-21 17:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-22 17:24 [PATCH v3] phy: cadence: Sierra: Add single link SGMII register configuration Marcin Wierzbicki
2023-05-23 12:15 ` Roger Quadros
2023-05-23 12:58 ` Marcin Wierzbicki
2023-06-21 17:39 ` Vinod Koul
2023-06-21 17:51   ` Vinod Koul [this message]
2023-07-11 11:25 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZJM4iUrlMIVwlfK+@matsya \
    --to=vkoul@kernel.org \
    --cc=bwawrzyn@cisco.com \
    --cc=danielwa@cisco.com \
    --cc=kishon@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mawierzb@cisco.com \
    --cc=olicht@cisco.com \
    --cc=rogerq@kernel.org \
    --cc=sjakhade@cadence.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox