From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: George Stark <gnstark@sberdevices.ru>
Cc: jic23@kernel.org, lars@metafoo.de, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
kernel@sberdevices.ru
Subject: Re: [PATCH v1 1/3] meson saradc: code refactoring
Date: Wed, 21 Jun 2023 17:08:45 +0300 [thread overview]
Message-ID: <ZJMEbbVaUoxSay5i@smile.fi.intel.com> (raw)
In-Reply-To: <20230621062715.455652-2-gnstark@sberdevices.ru>
On Wed, Jun 21, 2023 at 09:26:08AM +0300, George Stark wrote:
> - remove channel array double definition
> - add channel index enum
> - move enums declaration before variables declaration
> - move meson_sar_adc_set_chan7_mux routine upper
4 patches then?
...
> + // last item is temp channel
Is C++ comment style is used in the entire file?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-21 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 6:26 [PATCH v1 0/3] meson saradc: add iio channels to read channel 7 mux inputs George Stark
2023-06-21 6:26 ` [PATCH v1 1/3] meson saradc: code refactoring George Stark
2023-06-21 14:08 ` Andy Shevchenko [this message]
2023-06-21 6:26 ` [PATCH v1 2/3] meson saradc: add channel labels George Stark
2023-06-21 14:08 ` Andy Shevchenko
2023-06-21 6:26 ` [PATCH v1 3/3] meson saradc: support reading from channel7 mux inputs George Stark
2023-06-21 14:10 ` Andy Shevchenko
2023-06-21 14:10 ` [PATCH v1 0/3] meson saradc: add iio channels to read channel 7 " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJMEbbVaUoxSay5i@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gnstark@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox