From: Josh Triplett <josh@joshtriplett.org>
To: Allen Ballway <ballway@chromium.org>
Cc: arun.r.murthy@intel.com, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, jani.nikula@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/i915/quirk: Add quirk for devices that cannot be dimmed
Date: Thu, 22 Jun 2023 10:51:02 -0700 [thread overview]
Message-ID: <ZJSKBg+LymhvINoG@localhost> (raw)
In-Reply-To: <20230622172817.2281527-1-ballway@chromium.org>
On Thu, Jun 22, 2023 at 05:28:15PM +0000, Allen Ballway wrote:
> --- a/drivers/gpu/drm/i915/display/intel_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_backlight.c
> @@ -1192,6 +1192,11 @@ static u32 get_backlight_min_vbt(struct intel_connector *connector)
>
> drm_WARN_ON(&i915->drm, panel->backlight.pwm_level_max == 0);
>
> + if (intel_has_quirk(i915, QUIRK_NO_DIM)) {
> + /* Cannot dim backlight, set minimum to hightest value */
Typo: s/hightest/highest/
next prev parent reply other threads:[~2023-06-22 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 21:25 [PATCH] drm/i915/quirk: Add quirk for devices that cannot be dimmed Allen Ballway
2023-06-22 17:28 ` [PATCH v2] " Allen Ballway
2023-06-22 17:51 ` Josh Triplett [this message]
2023-06-29 17:21 ` [PATCH] " Allen Ballway
2023-08-08 17:39 ` [PATCH v3 RESEND] " Allen Ballway
2023-09-11 17:29 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJSKBg+LymhvINoG@localhost \
--to=josh@joshtriplett.org \
--cc=arun.r.murthy@intel.com \
--cc=ballway@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox