From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B7CEB64D8 for ; Thu, 22 Jun 2023 19:11:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbjFVTLb (ORCPT ); Thu, 22 Jun 2023 15:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjFVTL1 (ORCPT ); Thu, 22 Jun 2023 15:11:27 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4EBAA2; Thu, 22 Jun 2023 12:11:26 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 838203200583; Thu, 22 Jun 2023 15:11:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 22 Jun 2023 15:11:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= joshtriplett.org; h=cc:cc:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1687461085; x=1687547485; bh=yyY/dDd3tvUCahRRqoC7g6pyVZrYiHcN7zY pSqNwxsw=; b=CCLGmyLWdac+LsnQUf9Qqh1h3zTLhsgQiZmaaqOeysEf0xZDsMW u0k9GiqGFJtFW73vHY/cQnHmDHnex6t2v57f6//jd2ICOFco7zinccAvvXziqr89 NoWptFjJdvo6k/WhKj50xo/mGLocg2jBPot9Uj1tolFlPi2zwwYrjz3ojkUVcmHa f3NB4//YtMkG6BiIN12bHN6rayVxb9Z8vN3kJXzgoFFnOBiivcKyFO1CdbCJA8qV Sc/WKkxKbceTf1RQNOFHmDGfLWB7zgdNIuZh2VPdLcxAK14LLpo9EFTfFhCDjCQf /umvgxCDNyVsz9hHr+lH/mDV+1labBriXaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687461085; x=1687547485; bh=yyY/dDd3tvUCa hRRqoC7g6pyVZrYiHcN7zYpSqNwxsw=; b=BysV2FBqN+cX2CP3/Hdt8+oU+aQMW cpxrjDIxwLTX2J2JgYl1dmDqXNONwqyLssVK7KLdJY5mb9pQ5m0aZKVJfEhf6nBe eP0u7WxUh5GY7y6QSrjpxr+74vE5SUfK1lP7yaUcql1QxocGAhwHu1fYP8BrhB8s hS5hVbL9pOME5gmTcM6Gl/nyAeVLGC1uXd6hufq/jRKy5KcFjbVuo68YqTlOXEMG vV8ySil/4jeDVCD+qUmHRM9rBevfcc7UuZYXQcF2Y5EvnY+ULg6rGOM258Ycwetc qdIv5+XX8ec8D+skmsr3uRQN73NkCDQipQ1G1feEvv2BsbnaICXr4O5Pw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeeguddgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeflohhs hhcuvfhrihhplhgvthhtuceojhhoshhhsehjohhshhhtrhhiphhlvghtthdrohhrgheqne cuggftrfgrthhtvghrnhepvdekleffgfetfeeijedtieehtdeuhfegueejkeevueeileff gfduleffjeffuddvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhshhesjhhoshhhthhr ihhplhgvthhtrdhorhhg X-ME-Proxy: Feedback-ID: i83e94755:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jun 2023 15:11:22 -0400 (EDT) Date: Thu, 22 Jun 2023 12:11:21 -0700 From: Josh Triplett To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Ben Hutchings , linux-snps-arc@lists.infradead.org Subject: Re: [PATCH] kbuild: make modules_install copy modules.builtin(.modinfo) Message-ID: References: <20230615111743.883891-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230615111743.883891-1-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 08:17:43PM +0900, Masahiro Yamada wrote: > Josh Triplett reports that initramfs-tools needs modules.builtin and > modules.builtin.modinfo to create a working initramfs for a non-modular > kernel. > > If this is a general tooling issue not limited to Debian, I think it > makes sense to change modules_install. > > This commit changes the targets as follows when CONFIG_MODULES=n. > > In-tree builds: > make modules -> no-op > make modules_install -> install modules.builtin(.modinfo) > > External module builds: > make modules -> show error message like before > make modules_install -> show error message like before > > Link: https://lore.kernel.org/lkml/36a4014c73a52af27d930d3ca31d362b60f4461c.1686356364.git.josh@joshtriplett.org/ > Reported-by: Josh Triplett > Signed-off-by: Masahiro Yamada Reviewed-by: Josh Triplett Tested-by: Josh Triplett I'll send a followup patch that makes the Debian packaging script use `make modules_install` unconditionally.