From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: sfrench@samba.org, linkinjeon@kernel.org, shaggy@kernel.org
Cc: jfs-discussion@lists.sourceforge.net, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Duplicate unicode tables in smb/cifs/jfs
Date: Sun, 25 Jun 2023 14:28:49 +0000 [thread overview]
Message-ID: <ZJhPIYSUzBpuqosh@gallifrey> (raw)
Hi All,
I just tripped over three sets of duplicated unicode tables and
wondered if anyone had tried to rationalise them:
The pair of:
./fs/smb/server/uniupr.h
./fs/smb/client/cifs_uniupr.h
are identical except for formatting.
./fs/jfs/jfs_uniupr.c,
and I think this is the same with some change in variable name.
(I'm guessing the same thing is implemented in a bunch of
other places as well in a different way)
Would it make sense to swing fs/smb/server/uniupr.h up to
hmm, maybe fs/uniupr.h, remove any of the cifs_ prefixes
and then use the same include in all 3 places?
Maybe then later look at using some of the nls code?
Dave (who just tripped over this stuff)
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next reply other threads:[~2023-06-25 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 14:28 Dr. David Alan Gilbert [this message]
2023-06-26 17:00 ` Duplicate unicode tables in smb/cifs/jfs Dave Kleikamp
[not found] ` <CAH2r5mvwZnd+S8CmZGQSdtnAWD45YjFx-1j0EaFBR3Qn-SjHEA@mail.gmail.com>
2023-06-27 0:40 ` Dr. David Alan Gilbert
[not found] ` <CAH2r5mvEWeSOM=NYrxSG1EZ1py-DSkOrwEyh+_L-KuFLVWktQw@mail.gmail.com>
2023-06-27 10:42 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJhPIYSUzBpuqosh@gallifrey \
--to=linux@treblig.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox