From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C055EB64DC for ; Mon, 26 Jun 2023 06:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229660AbjFZGVw (ORCPT ); Mon, 26 Jun 2023 02:21:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjFZGVu (ORCPT ); Mon, 26 Jun 2023 02:21:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4947EF3 for ; Sun, 25 Jun 2023 23:21:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D30ED60C88 for ; Mon, 26 Jun 2023 06:21:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDD2CC433C0; Mon, 26 Jun 2023 06:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687760508; bh=32adzyDlBFSBWtLEHoNT9pfLD4gF8dQdYVhhOXCfYD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WBqcc90oaWhYQCR+OXO6W6iA1ACE4SzpeVklyw8fJfxPwJz0K1YH3vIWMR84qSpaj OrwYeLr4DbDJTVWnrcaD6KDbdQfSQYSBFWOOlpgL7jB5vbzolI8iBDnA8JE6OPkBXm dbvViJB9f/0YTRMiBWnmnqVTLdOvLE/q63nO1zmW4NZXPmirC0L4RdZ4FCCQvKEqdv cPZ7mpUXnXdKxc1ryne6q4P3oABniHLHIoXGnVSLHcnSmNsERVnEm92VyNEuD7TaMA D2qtgyLYu1om93dBNc/LnJQpSuRvj5dz5MDHFvj+flBUWndo6hVGKx6EZtOH/8naDz xJWbQFYxOOYjg== Date: Mon, 26 Jun 2023 09:21:42 +0300 From: Mike Rapoport To: Yajun Deng Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node() Message-ID: References: <20230625050850.GJ52412@kernel.org> <20230624024622.2959376-1-yajun.deng@linux.dev> <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 25, 2023 at 07:39:10AM +0000, Yajun Deng wrote: > June 25, 2023 1:08 PM, "Mike Rapoport" wrote: > > > On Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote: > > > >> It only returns address now in memblock_find_in_range_node(), we can add a > >> parameter pointing to integer for node id of the range, which can be used > >> to pass the node id to the new reserve region. > >> > >> Introduce memblock_reserve_node() so that the node id can be passed to > >> the reserve region in memblock_alloc_range_nid(). > >> > >> Signed-off-by: Yajun Deng > > > > What problem does this patch solve? > > > > If we set nid and flags in memblock_alloc_range_nid(), we may not need > memblock_set_node() in memmap_init_reserved_pages(). When memblock_reserve() is called before NUMA setup, the node ids are still unset in memblock.memory, so very early reservations will be missed and we still have to update node ids in memblock.reserved later. > I tested this patch and delete memblock_set_node() in memmap_init_reserved_pages(). > It works fine. I did not delete memblock_set_node() in this patch just in case. -- Sincerely yours, Mike.