Re: [GIT PULL] bcachefs

Jens Axboe
2023-06-28T14:59:21Z

On 6/28/23 8:48 AM, Thomas Weißschuh wrote:
> On 2023-06-28 08:40:27-0600, Jens Axboe wrote:
>> On 6/27/23 4:05?PM, Dave Chinner wrote:
>> [..]
>
>>> There should be no reason to need to specify the filesystem type for
>>> filesystems that blkid recognises. from common/config:
>>>
>>> # Autodetect fs type based on what's on $TEST_DEV unless it's been set
>>> # externally
>>> if [ -z "$FSTYP" ] && [ ! -z "$TEST_DEV" ]; then
>>> FSTYP=`blkid -c /dev/null -s TYPE -o value $TEST_DEV`
>>> fi
>>> FSTYP=${FSTYP:=xfs}
>>> export FSTYP
>>
>> Gotcha, yep it's because blkid fails to figure it out.
>
> This needs blkid/util-linux version 2.39 which is fairly new.
> If it doesn't work with that, it's a bug.

Got it, looks like I have 2.38.1 here.

--
Jens Axboe