From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D30EB64D9 for ; Tue, 27 Jun 2023 04:30:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230078AbjF0Ea1 (ORCPT ); Tue, 27 Jun 2023 00:30:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjF0EaL (ORCPT ); Tue, 27 Jun 2023 00:30:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 651EC97; Mon, 26 Jun 2023 21:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+r8p/v5s7wbLIPfSeJmQ/Jnc8OoL0+y1yUUWCSbGtuo=; b=mC8i7Dn84t1nQu2SXZOo0VXBPi 6GNIEqUOKZCP4LQWlB/pldb33gsvunRvnV6Ukm9rE4T4N7kH00nBcG53PLhHmcWdplIzyAUkSunGW Ovhky/bUBuI0LV5kB4QKOOFCWm2IYpOwskAcyfGSoCRwi/InTaYQQoi78xUahRsiX/QTLbhBkDWRD +iFriABvNMURanj7kUTHF7+7OCKBK45EgNAwvYnUW8S7X/O7huGFuwDjQHHw1X/QuSkqyX7FGRn3G CjI8LYX/W/t+F0d3qEELi/fOl9CMfnIb/32IbsqyZbxNI/KNTLFhaT/kqA+1S6EUmutxvxhHNZbLj 5FgZJSrQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE0L9-00Bh4b-08; Tue, 27 Jun 2023 04:30:07 +0000 Date: Mon, 26 Jun 2023 21:30:07 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 07/12] writeback: Factor writeback_iter_init() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-8-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2023 at 06:35:16PM +0100, Matthew Wilcox (Oracle) wrote: > + for (folio = writeback_iter_init(mapping, wbc); > + folio; > + folio = writeback_get_next(mapping, wbc)) { Ok that's another way to structure it. Guess I should look over the whole series first..