From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0CE8EB64DC for ; Tue, 27 Jun 2023 16:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231237AbjF0QQ3 (ORCPT ); Tue, 27 Jun 2023 12:16:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbjF0QQ1 (ORCPT ); Tue, 27 Jun 2023 12:16:27 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0E722946 for ; Tue, 27 Jun 2023 09:16:25 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-262bf824505so1283a91.1 for ; Tue, 27 Jun 2023 09:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687882585; x=1690474585; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=wKCZPhCEoRc2hrFofo6TcR+e3uVxroaKugj4hSasIz4=; b=wv+by0SriSajzT+2XIqEDT28zSYRBBs8Rp8uYg4K9k6Wsu5XMFBv5O9AIQshwERDEQ XarL7vAonCfVPlfC1Mk+S6fy9hlYIXK3f+Ae81yBlrd1/UywHwE8g/4NboAAuGcGGNMa giDTBkXtdf8lEsf7vbZHl+4rlXJKRDfLbwbMNpLYePcfGaPZoeyog4YMoI6dafdp+hdu pCWhZvDh4poO45mGI1q8GE+upySHw8y44rtIPAYLNK4hifTNv2E7G4akHIbgJRWATNuf 1Q4o2x3ZcLyn99p32Yd6MAJuumzKPh8Lw89MTnTFzlxDKtu2h4+8jjkDLl1ynCRVpWnJ cusg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687882585; x=1690474585; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wKCZPhCEoRc2hrFofo6TcR+e3uVxroaKugj4hSasIz4=; b=R5hBQgcaoXGNgFi/Kx9PL7QiuTls4K6DcLfUmTWnHahZQuHfS1vvy/I/YmDfGj9nl+ B1l3xjRaDlBb0RbErb7AeH21oYgKdjvEJYcK51eEczkmdnu5O7qqqIe3A6OFEyXb8F5Z Rbz5tg/zmUGz4sQ/+Z8usErdCK41j9Q1Lr3JA7QgUco75EoWC7Prz0CMICQefki3z8GH BfZdAVVDV8qP7mha3q30l4UMamTBJTB0+miL05KB5LxNgaXAxAG8vvLbnjOcNYeDKeZO VnoyF7rTRtNSxOozf6P+GYQoysBEMrXis1dv7bU3mSJEXM3ebbNAXBIPuwcHnq44AF0Z Wc0A== X-Gm-Message-State: AC+VfDyzZUHHCa60mP1I2gnQYUHzvRWJzKJksl7eIU9f4OnAoFtxI4RL DIN6UlJCExqmM6QPwLW0zlUC2hKZBtU= X-Google-Smtp-Source: ACHHUZ62vvfMawNXLc5hGBJfx6LqoonyWGDMSdygAGWq2/PldG1BPMO2N03oq360iSWTrVdUlKxr/i08jsE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:e281:b0:263:25f9:6588 with SMTP id d1-20020a17090ae28100b0026325f96588mr256696pjz.1.1687882585393; Tue, 27 Jun 2023 09:16:25 -0700 (PDT) Date: Tue, 27 Jun 2023 09:16:23 -0700 In-Reply-To: <20230626182016.4127366-7-mizhang@google.com> Mime-Version: 1.0 References: <20230626182016.4127366-1-mizhang@google.com> <20230626182016.4127366-7-mizhang@google.com> Message-ID: Subject: Re: [PATCH v2 6/6] KVM: Documentation: Add the missing description for tdp_mmu_page into kvm_mmu_page From: Sean Christopherson To: Mingwei Zhang Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Huang , Jim Mattson , David Matlack , Ben Gardon , Xu Yilun , Zhi Wang Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2023, Mingwei Zhang wrote: > Add the description for tdp_mmu_page into kvm_mmu_page description. > tdp_mmu_page is a field to differentiate shadow pages from TDP MMU and > non-TDP MMU. When TDP MMU is enabled, sp->tdp_mmu_page=1 indicates a shadow > page for L1, while sp->tdp_mmu_page=0 indicates a shadow page for an L2. > When TDP MMU is disabled, sp->tdp_mmu_page is always 0. So update the doc > to reflect the information. > > Signed-off-by: Mingwei Zhang > --- > Documentation/virt/kvm/x86/mmu.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/virt/kvm/x86/mmu.rst b/Documentation/virt/kvm/x86/mmu.rst > index cc4bd190c93d..678dc0260a54 100644 > --- a/Documentation/virt/kvm/x86/mmu.rst > +++ b/Documentation/virt/kvm/x86/mmu.rst > @@ -278,6 +278,8 @@ Shadow pages contain the following information: > since the last time the page table was actually used; if emulation > is triggered too frequently on this page, KVM will unmap the page > to avoid emulation in the future. > + tdp_mmu_page: > + Is 1 if the shadow page is a TDP MMU page. Maybe add a short blurb explaining that it's used for control flow when starting from a common entry point? E.g. walking page tables given a root, and walking lists that can hold both shadow MMU and TDP MMU pages.