From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: You Kangren <youkangren@vivo.com>
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Damian Muszynski <damian.muszynski@intel.com>,
Srinivas Kerekare <srinivas.kerekare@intel.com>,
"open list:QAT DRIVER" <qat-linux@intel.com>,
"open list:CRYPTO API" <linux-crypto@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com
Subject: Re: [PATCH v2] crypto: qat - Replace the if statement with min()
Date: Wed, 28 Jun 2023 13:46:44 +0300 [thread overview]
Message-ID: <ZJwPlLC7/sJP8U7u@smile.fi.intel.com> (raw)
In-Reply-To: <20230627071726.20578-1-youkangren@vivo.com>
On Tue, Jun 27, 2023 at 03:17:24PM +0800, You Kangren wrote:
> Replace the if statement with min_t() to simplify the code
...
> - if (words_num < UWORD_CPYBUF_SIZE)
> - cpylen = words_num;
> - else
> - cpylen = UWORD_CPYBUF_SIZE;
> + cpylen = min_t(unsigned int, words_num, UWORD_CPYBUF_SIZE);
min_t() can be dangerous some times.
To make it robust I would suggest to use min() and mark UWORD_CPYBUF_SIZE
with U suffix to make the type the same.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-06-28 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:17 [PATCH v2] crypto: qat - Replace the if statement with min() You Kangren
2023-06-28 10:46 ` Andy Shevchenko [this message]
2023-06-28 13:11 ` [PATCH] crypto: qat - use min() in fw loader Giovanni Cabiddu
2023-06-28 14:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJwPlLC7/sJP8U7u@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=damian.muszynski@intel.com \
--cc=davem@davemloft.net \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=qat-linux@intel.com \
--cc=srinivas.kerekare@intel.com \
--cc=tom.zanussi@linux.intel.com \
--cc=youkangren@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox