From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Steve French <smfrench@gmail.com>
Cc: Dave Kleikamp <dave.kleikamp@oracle.com>,
krisman@collabora.com, Tom Talpey <tom@talpey.com>,
sfrench@samba.org, linux-cifs@vger.kernel.org,
jfs-discussion@lists.sourceforge.net, linkinjeon@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [Jfs-discussion] [PATCH 0/3] dedupe smb unicode files
Date: Wed, 28 Jun 2023 15:13:19 +0000 [thread overview]
Message-ID: <ZJxOD+OZzq3FR1dH@gallifrey> (raw)
In-Reply-To: <CAH2r5ms1UE4vAuakBLuayv1CXw3sC_OcuhtCrz5mV_ftR+=rjg@mail.gmail.com>
* Steve French (smfrench@gmail.com) wrote:
> On Wed, Jun 28, 2023 at 9:40 AM Dr. David Alan Gilbert
> <linux@treblig.org> wrote:
> > > > Actually, would you be ok with smb_unicode_common ? The reason is that
> > > > you end up with a module named unicode_common that sounds too generic.
> > >
> > > I'd suggest make it generic and move it to fs/nls/. I'd run it by the nls
> > > maintainers, but I don't think there are any.
> >
> > Steve & Tom - would you be OK with that?
>
> Yes - absolutely
OK.
> > (Copying in Gabriel Bertazi, owner of fs/unicode; although this isn't
> > utf-8)
>
> Unicode UCS-2
(I'm going to regret the next question...)
So how does this compare to the stuff in include/linux/ucs2_string.h
and lib/ucs2_string.c ?
Dave
>
> --
> Thanks,
>
> Steve
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2023-06-28 15:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 1:14 [PATCH 0/3] dedupe smb unicode files linux
2023-06-28 1:14 ` [PATCH 1/3] fs/smb: Remove unicode 'lower' tables linux
2023-06-28 1:14 ` [PATCH 2/3] fs/smb: Swing unicode common code from server->common linux
2023-06-28 15:06 ` Namjae Jeon
2023-06-28 17:31 ` Dr. David Alan Gilbert
2023-06-28 1:14 ` [PATCH 3/3] fs/smb/client: Use common code in client linux
2023-06-28 13:15 ` [PATCH 0/3] dedupe smb unicode files Tom Talpey
2023-06-28 13:41 ` Dr. David Alan Gilbert
2023-06-28 13:46 ` Dr. David Alan Gilbert
2023-06-28 14:02 ` [Jfs-discussion] " Dave Kleikamp
2023-06-28 14:11 ` Tom Talpey
2023-06-28 14:39 ` Dr. David Alan Gilbert
2023-06-28 15:01 ` Tom Talpey
2023-06-28 15:03 ` Steve French
2023-06-28 15:13 ` Dr. David Alan Gilbert [this message]
2023-06-28 14:02 ` Steve French
2023-06-28 14:17 ` [Jfs-discussion] " Dave Kleikamp
2023-06-28 14:47 ` Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJxOD+OZzq3FR1dH@gallifrey \
--to=linux@treblig.org \
--cc=dave.kleikamp@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=krisman@collabora.com \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox