From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63D0EB64DC for ; Wed, 28 Jun 2023 17:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229662AbjF1RcM (ORCPT ); Wed, 28 Jun 2023 13:32:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229645AbjF1RcJ (ORCPT ); Wed, 28 Jun 2023 13:32:09 -0400 Received: from mx.treblig.org (unknown [IPv6:2a00:1098:5b::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 189C71715; Wed, 28 Jun 2023 10:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=treblig.org ; s=bytemarkmx; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID :Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID :Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To: Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe :List-Post:List-Owner:List-Archive; bh=4mtcRlXWQpbbslXjCfhS0B8/3iHNiw5vVznGMLX6XwQ=; b=hN89nE4eelVc4iK+8FPnE7PZBr RF4dDkftNlYx1W/yDLUC661l1MUszbN91MrC25V6MePXXjZxbb1zMAZbg7yYAP07MnLn3/Iwrelua tcX5YGVUWJ9eBW86grHHxwSkKh8suyGLVEFLgbFLcfb623nskQm0U8l8lNuLLkG4YPRfSyFEqArt5 c7knLC1K310NXbKBDnNRDN4wryygsQ7ARZhqlFbl5yOkG/6q3DtC411EzOni4EW5QTIRZnsUgSzx6 i1oZWGj7d/+ZfNdtIanqrfvNFvP8bbePZrKiFc3ZKpDKjUT2QQMbK7pdVliG1orAwZS6lcBvh2Ujt SalUM0ng==; Received: from dg by mx.treblig.org with local (Exim 4.94.2) (envelope-from ) id 1qEZ1C-00GV9p-AS; Wed, 28 Jun 2023 17:31:50 +0000 Date: Wed, 28 Jun 2023 17:31:50 +0000 From: "Dr. David Alan Gilbert" To: Namjae Jeon Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] fs/smb: Swing unicode common code from server->common Message-ID: References: <20230628011439.159678-1-linux@treblig.org> <20230628011439.159678-3-linux@treblig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: X-Chocolate: 70 percent or better cocoa solids preferably X-Operating-System: Linux/5.10.0-21-amd64 (x86_64) X-Uptime: 17:31:26 up 101 days, 4:05, 1 user, load average: 0.00, 0.00, 0.00 User-Agent: Mutt/2.0.5 (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Namjae Jeon (linkinjeon@kernel.org) wrote: > 2023-06-28 10:14 GMT+09:00, linux@treblig.org : > > From: "Dr. David Alan Gilbert" > > > > Swing most of the inline functions and unicode tables into smb/common > > from the copy in smb/server. > > > > UniStrcat has different types between the client and server > > versions so I've not moved it (although I suspect it's OK). > ksmbd doesn't use this function. You can move it to smb_unicode_common.h. Ah OK, thanks. Dave > Thanks. -- -----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/