From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2546DEB64D7 for ; Wed, 28 Jun 2023 21:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232131AbjF1VFr (ORCPT ); Wed, 28 Jun 2023 17:05:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbjF1VFc (ORCPT ); Wed, 28 Jun 2023 17:05:32 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECC261FCD for ; Wed, 28 Jun 2023 14:05:30 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-528ab7097afso86288a12.1 for ; Wed, 28 Jun 2023 14:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687986330; x=1690578330; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=iTvXYleREN2yij4E2iUrdc4+zuDCLfU8CgECkdsXphw=; b=cWI8VVVE+Ru56ZbxlSZbx0tMknUOLoqjPH2JPTt5mLCocaJ8gX7Q5GfqTwyw8XGY8y PfVI/cEtyzXfxg7+mvUwpRuRl8eqK2/VCy6afjdbJRkR8A2uHG24VcLPUGeumDdw6wjW /fjXoTwo87IoY9+EB/D/baO17ET5i726YMsEH7tSlt/sXxBioH+K8WmOXUlU72OViZfg ZrNji/5MZPDtDPaMe82Gi1qOcIgK2lfxMPkYbzXrIFmxCb2H+Cj9fBUE3W7ZP0ZiojA7 RD2Bb+g+RkrEX3P7+KT+cZ5/6FqEUiHFxd5KyRD8R+ssSw+LTo8zcHZgVs1QkDkyi08X miIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687986330; x=1690578330; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iTvXYleREN2yij4E2iUrdc4+zuDCLfU8CgECkdsXphw=; b=EFLzrzK2aMOymAgVM/8VM+ueEKOKzBpGSORRQYFtiPXhScz0e941BaWsFpO7KJzBbv /s1Np77ekZE9BQNM4jOOuwlzDmbvHbUqGV4Wcrf2Byzv9U4vYVNJvYadVEu9EueQ7KpC g/UAx5joXknNRk4jQpLnw/rXn/4YpUZvKs09TIhiD6R6FDJXxdcHW2v7Tr/2vcnhFUh7 2CRi7i+ftMGGQQjYfFoWOMMPTeti9bYAuCO5xWDRBx2fmyY1oan5tFVQMiH3FpURaYau pfo5qJRr+LOSbWTMJpykY9G1qzHfyz15FLIPjIs9W9722KCDstn324jh67THre8CT9Mi cpgw== X-Gm-Message-State: AC+VfDxz7CHovrzWv3OCs9W9tSDhn48YmI+xhmZ1gNeB5ibGvYsefGlN SwEJ7/3BAwCRWnLder5YnMscEJMe/ns= X-Google-Smtp-Source: ACHHUZ7fKOO6PjrVD51fLP7DRQhQIYqcdFWnENpYf47eYPEkqJ8jK/51l1raBdyO8JzNi4eZWC0Mxh4VHnA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:e954:0:b0:55a:c91e:4121 with SMTP id q20-20020a63e954000000b0055ac91e4121mr969253pgj.5.1687986330389; Wed, 28 Jun 2023 14:05:30 -0700 (PDT) Date: Wed, 28 Jun 2023 14:05:28 -0700 In-Reply-To: <20230530134248.23998-8-cloudliang@tencent.com> Mime-Version: 1.0 References: <20230530134248.23998-1-cloudliang@tencent.com> <20230530134248.23998-8-cloudliang@tencent.com> Message-ID: Subject: Re: [PATCH v2 7/8] KVM: selftests: Test Intel supported fixed counters bit mask From: Sean Christopherson To: Jinrong Liang Cc: Paolo Bonzini , Like Xu , David Matlack , Aaron Lewis , Vitaly Kuznetsov , Wanpeng Li , Jinrong Liang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 30, 2023, Jinrong Liang wrote: > +static void test_fixed_counters_setup(struct kvm_vcpu *vcpu, uint8_t edx_fix_num, > + uint32_t fixed_bitmask, bool expected) > +{ > + struct kvm_cpuid_entry2 *entry; > + uint8_t max_fixed_num = X86_INTEL_MAX_FIXED_CTR_NUM; > + uint64_t supported_bitmask = 0; > + uint64_t msr_val; > + unsigned int i; > + > + entry = vcpu_get_cpuid_entry(vcpu, 0xa); > + entry->ecx = fixed_bitmask; > + entry->edx = (entry->edx & ~FIXED_CTR_NUM_MASK) | edx_fix_num; > + vcpu_set_cpuid(vcpu); > + > + for (i = 0; i < max_fixed_num; i++) { > + if (entry->ecx & BIT_ULL(i) || > + ((entry->edx & FIXED_CTR_NUM_MASK) > i)) > + supported_bitmask |= BIT_ULL(i); > + } > + > + vcpu_args_set(vcpu, 2, supported_bitmask, max_fixed_num); All of this can be queried from the guest, no? Then you also verify that KVM is passing in the correct CPUID info too. > + while (run_vcpu(vcpu, &msr_val) != UCALL_DONE) > + TEST_ASSERT(!!msr_val == expected, > + "Unexpected when testing fixed counter."); ASSERT_EQ()