From: Sean Christopherson <seanjc@google.com>
To: Jinrong Liang <ljr.kernel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>, Shuah Khan <shuah@kernel.org>,
Aaron Lewis <aaronlewis@google.com>,
David Matlack <dmatlack@google.com>,
Vishal Annapurve <vannapurve@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Like Xu <like.xu.linux@gmail.com>,
Jinrong Liang <cloudliang@tencent.com>,
linux-kselftest@vger.kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] KVM: selftests: Test gp event filters don't affect fixed event filters
Date: Wed, 28 Jun 2023 14:30:37 -0700 [thread overview]
Message-ID: <ZJymfTf+fRFnDsyW@google.com> (raw)
In-Reply-To: <20230607123700.40229-5-cloudliang@tencent.com>
On Wed, Jun 07, 2023, Jinrong Liang wrote:
> static void __test_fixed_counter_bitmap(struct kvm_vcpu *vcpu, uint8_t idx,
> uint8_t nr_fixed_counters)
> {
> @@ -881,6 +894,25 @@ static void __test_fixed_counter_bitmap(struct kvm_vcpu *vcpu, uint8_t idx,
> bitmap);
> TEST_ASSERT(!!count == !(bitmap & BIT(idx)),
> "Fixed event filter does not work as expected.");
> +
> + /*
> + * Check that setting both events[] and fixed_counter_bitmap
> + * does not affect the consistency of the fixed ctrs' behaviour.
Spell out "counters". And this isn't about "consistency", the fixed_counter_bitmap
should straight up win, i.e.
/*
* Check that fixed_counter_bitmap has higher priority than
* events[] when both are set.
*/
prev parent reply other threads:[~2023-06-28 21:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 12:36 [PATCH v3 0/4] KVM: selftests: Improve PMU event filter settings and add test cases Jinrong Liang
2023-06-07 12:36 ` [PATCH v3 1/4] KVM: selftests: Introduce __kvm_pmu_event_filter to improved event filter settings Jinrong Liang
2023-06-28 21:19 ` Sean Christopherson
2023-06-30 2:47 ` Jinrong Liang
2023-06-07 12:36 ` [PATCH v3 2/4] KVM: selftests: Test unavailable event filters are rejected Jinrong Liang
2023-06-28 21:26 ` Sean Christopherson
2023-06-07 12:36 ` [PATCH v3 3/4] KVM: selftests: Check if event filter meets expectations on fixed counters Jinrong Liang
2023-06-28 21:29 ` Sean Christopherson
2023-06-07 12:37 ` [PATCH v3 4/4] KVM: selftests: Test gp event filters don't affect fixed event filters Jinrong Liang
2023-06-28 21:30 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJymfTf+fRFnDsyW@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=cloudliang@tencent.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ljr.kernel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=vannapurve@google.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox