From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED73EB64DA for ; Wed, 28 Jun 2023 21:30:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232039AbjF1Vap (ORCPT ); Wed, 28 Jun 2023 17:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbjF1Val (ORCPT ); Wed, 28 Jun 2023 17:30:41 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45F891BEA for ; Wed, 28 Jun 2023 14:30:40 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-bb2202e0108so163226276.1 for ; Wed, 28 Jun 2023 14:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687987839; x=1690579839; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=VcnjYg/WB2vQn+tBGvK3Q2gluatWaUqvXxEopMzKdso=; b=nBCEFq9b2TG3gseb06QDgnUtN/CScBK+uLIbOaLLRsI3KJk84omXwh3k8Fj4OMTxi7 TWGDjSmRl95Za+Hc1FBI/a1ypwBtn4txANo14deOfMtjacON+9hju13X74roaEUQd5WY fKQyjYRf1wHfKWXBhRWvTg1azXTGz2C+RoDWlQEksAORrVyZNlkbDXLH9k/y9tp73P3i ZJAUAyMhFFbWYUTpGgLaOhoRTDUKP9+ebdp00PodHiXW1qlx0Bz17w58BRy538VJcFbM B8v4CiztnM28Vj536xtLaLbwutOFZrYY6jDpo4b5N+VeJw17SSvHoaD5q/0HknmbBDRQ 3o8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687987839; x=1690579839; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VcnjYg/WB2vQn+tBGvK3Q2gluatWaUqvXxEopMzKdso=; b=ePYIfdMS575Z+hVyb3TXYiqELW56X6ErF9f3ENruicglA+Rfw/tH4vTB7wxOLHsPVT 9184PLv78tsll/wJ1Hr50BfLCaEfGJGifDDSs9xLX7EYGAWPk2xHZM5e0wtbYLslLuHr KxIheAKKDAlqUmA96t3AWXwP83sR+VnVuIblbSMcxqiEtal8LXAJ3zHcTs7g1vpAjjwO fbmugCxeKhfRewG0jOE0IfPN0DPe0wxUtJaEXrhho0xE2sp259T0nWf2tMx1hZG8BM1S 8ZZKuAhE/K3yWLfFgu51BxIclbnUoT+CyUMAdthDd/c7SsPBWWylDtoTcNEf7nkRRj2H dW3g== X-Gm-Message-State: AC+VfDzCcCuYw41RQRHrVVfilRwitWTo8OsRvbDhpLRLumyKAK8qUXXS LE4LKhAAkAfueMx24/lzSLhlM+BHBxI= X-Google-Smtp-Source: ACHHUZ5XelWl+F2ma1SfdrNipVHrp8infBaeoZzX2b9ZqRCrkICVXeVBv8pkxbJ+G47QSPPaNsQPsAdxz0Y= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:ab6b:0:b0:c1b:4347:b3db with SMTP id u98-20020a25ab6b000000b00c1b4347b3dbmr3335327ybi.6.1687987839556; Wed, 28 Jun 2023 14:30:39 -0700 (PDT) Date: Wed, 28 Jun 2023 14:30:37 -0700 In-Reply-To: <20230607123700.40229-5-cloudliang@tencent.com> Mime-Version: 1.0 References: <20230607123700.40229-1-cloudliang@tencent.com> <20230607123700.40229-5-cloudliang@tencent.com> Message-ID: Subject: Re: [PATCH v3 4/4] KVM: selftests: Test gp event filters don't affect fixed event filters From: Sean Christopherson To: Jinrong Liang Cc: Paolo Bonzini , Jim Mattson , Shuah Khan , Aaron Lewis , David Matlack , Vishal Annapurve , Wanpeng Li , Like Xu , Jinrong Liang , linux-kselftest@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 07, 2023, Jinrong Liang wrote: > static void __test_fixed_counter_bitmap(struct kvm_vcpu *vcpu, uint8_t idx, > uint8_t nr_fixed_counters) > { > @@ -881,6 +894,25 @@ static void __test_fixed_counter_bitmap(struct kvm_vcpu *vcpu, uint8_t idx, > bitmap); > TEST_ASSERT(!!count == !(bitmap & BIT(idx)), > "Fixed event filter does not work as expected."); > + > + /* > + * Check that setting both events[] and fixed_counter_bitmap > + * does not affect the consistency of the fixed ctrs' behaviour. Spell out "counters". And this isn't about "consistency", the fixed_counter_bitmap should straight up win, i.e. /* * Check that fixed_counter_bitmap has higher priority than * events[] when both are set. */