From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AF4C0015E for ; Thu, 13 Jul 2023 06:52:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234082AbjGMGwI (ORCPT ); Thu, 13 Jul 2023 02:52:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229851AbjGMGwG (ORCPT ); Thu, 13 Jul 2023 02:52:06 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77953E8; Wed, 12 Jul 2023 23:52:03 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4f4b2bc1565so636769e87.2; Wed, 12 Jul 2023 23:52:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689231122; x=1691823122; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=rjioKYAE1CabhlLXtOYpTpcQpvMCu8spfeCxR4rurZ0=; b=Ub0AcfBwr4qZaN1b5EuddxfYLDiavFGhJgnnzehpRCG54rbfHFjK0NRWs22HqazOg/ 7+USN0vVUzA7Rm5rIFKqNJ00fuQo3us8YG17i668XQBAPDKxp8jI3yUhWyA7xdFQ8OSc 031+iKbTtvrhYCHXbDq1PL/u4w3CR8ri3mGDIID9OORzmvt+r9vbWCNOBZc/VFmYBzej aVozqoCEafC5HdbU13p9oBV+8R4ngGCwVC834Y5BnHYxUxuCyjM1CzwqqQenRlzjahxl x+NKv4nuPGCkbApOe4bFvORgRT+ER8BiRgXxwyKWSw9ugFEfXU3zayaK81GOU0eM/a69 hj5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689231122; x=1691823122; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rjioKYAE1CabhlLXtOYpTpcQpvMCu8spfeCxR4rurZ0=; b=aZTK9xYsP2j+3ozxVTeQNyUkkTbJrVCYP7EGthePY0/a+WL57j1T/63Jys7xK9N6yh V2ZqYimT0xod0RQu437LWx0KZXKxarKYjOYQhoJET0Gs7g+84B0E3xqOPlRcz56lI4Pa XHX0TAryoOt7Yt6GWXG+USIyC5fWG8Qp0KQa7yQeSHG5oKVoLNKODcSyfZEMOSlgqqH8 nAZXG+RDXOUQv9/bM/JYMsNIxnskEnMCaIjFnqhC/237ytT8To3w6F4p11weCDjFpm0Z juACrOoO3gR/kPoxK8RM/YX9nJfqjstL4chIyqh+ZjA/ft4gVK2GdnzY89w/2YuIqk7G fy/A== X-Gm-Message-State: ABy/qLYdczdrZARBPb8zkiPbTpOXPrH/+rgjQKCCPyNeN7+FKzy6Y4QD 65wUICYA2ElNwAHD3lUoDGw= X-Google-Smtp-Source: APBJJlF9RwSK0SfzuOclhMfYGva33E1IsP+9+wjEV6a2OCouK3ZdXv2iGFDIuCWeHAJ2t3hZiTg4/g== X-Received: by 2002:a05:6512:3f5:b0:4fb:758c:74ed with SMTP id n21-20020a05651203f500b004fb758c74edmr406388lfq.35.1689231121362; Wed, 12 Jul 2023 23:52:01 -0700 (PDT) Received: from orome (p200300e41f4b7100f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f4b:7100:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id u8-20020a056402064800b0051e2549c4f9sm3899928edx.47.2023.07.12.23.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 23:52:00 -0700 (PDT) Date: Thu, 13 Jul 2023 08:51:59 +0200 From: Thierry Reding To: Minjie Du Cc: Krishna Reddy , Joerg Roedel , Will Deacon , Robin Murphy , Jonathan Hunter , "open list:TEGRA IOMMU DRIVERS" , "open list:IOMMU SUBSYSTEM" , open list , opensource.kernel@vivo.com Subject: Re: [PATCH v2] iommu: remove redundant parameter check in tegra_smmu_debugfs_init() Message-ID: References: <20230713025653.1540-1-duminjie@vivo.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xgyxSMOb3u6QlwA/" Content-Disposition: inline In-Reply-To: <20230713025653.1540-1-duminjie@vivo.com> User-Agent: Mutt/2.2.10 (2023-03-25) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --xgyxSMOb3u6QlwA/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 13, 2023 at 10:56:53AM +0800, Minjie Du wrote: > debugfs_create_file() will simply return early if > smmu->debugfs is an error pointer. The formatting is a little weird here. > Make smmu->debugfs check delete in tegra_smmu_debugfs_init(). I think something like this is better: Delete smmu->debugfs check in ... Or perhaps combine both sentences: debugfs_create_file() will return early if smmu->debugfs is an error pointer, so an extra error check is not needed. With that fixed: Acked-by: Thierry Reding --xgyxSMOb3u6QlwA/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSvnwwACgkQ3SOs138+ s6FbVA/9FLgDdG1LKZ0l03k73D7pZ4qnDFuB6IVJdEl+WnEIIbuytEtjgVi3Qu3A +5DGHteJ8CZAiBVtZit97kUvHSlWFvBV4Nk0wi2JMNtCZ4zhAoysEWwhlDuHqVGP S6cDWlLP9mJqKV+K6TwONKbO1SeqcKiWPiFVuO+aqORu4KAQ2Yf71YmvaxfsTawk UN6Fd/uLsTwnVv5/LJqJ1IUr6UbfRXbKTvlJAgcwncRE73bvI8zxt6dgFwl1WpIV mmR9e5TPCo78r5qogRaUZPE8t8DkbRBJ4BSE/KMRyq4qxwrfAHwmJCCI3aPMHscw Vp6QRO92vta0c/UxEIbyCvyMEG+2usGxlsYzjJNXWKXwi2MTZL/+GEhqO+FASnBL xzRpd+3kKsoKDyTwBtN6HRrJfqtwjvYCAtq1EuZZMMXpNEZgnt5/Skt1Wo0QwYyo UDotUuoUGECDlA/GP98R2htx7c+hIytmKV88WLK3NOL1QpnPiXHeR4h6obH7h9oc MfgaSBN39KwsdKACFqSANMjhgJcO65apgelD0/OZDm1MHSkOsT5cPz9S4qpwtsUg 1T//VsYjA+lLfZNvoE+trCeIHqatZpAkouzJEqacc5vVGE0WqpAuDa9gvYa/MKcZ s20oZW/FydwDx0IGCWyr3296bglGsmSicACaCVugDj5/OtuMHxs= =oFY6 -----END PGP SIGNATURE----- --xgyxSMOb3u6QlwA/--