From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD49AC001DF for ; Tue, 11 Jul 2023 11:11:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231618AbjGKLLA (ORCPT ); Tue, 11 Jul 2023 07:11:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230421AbjGKLK4 (ORCPT ); Tue, 11 Jul 2023 07:10:56 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 077D698; Tue, 11 Jul 2023 04:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689073856; x=1720609856; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=C71aeTJAOI/hMDyIcMR24A6iht2n+gbfSGfP4xzAt6Q=; b=lTEdBKaqGoh2TYYIvC8GXSt7kVqoAk464mqijRUYi4NK3ltsw2JxYj+A sjFKVqEd53ajVpaaUPR+1jRIfDpj8dVGVPFx02djabj/8Fm78N5YG3uj6 b4ebub6QZPykQ82DCaKRNzA0cxh+3S/MfJMwJrVdi5dJB6SCAyA7W+kd8 4+jVzbF9c91+uAwM/1HEmWDjuZ8Q3g6PejtklHFVPS8gEj61uagu8/gT/ ycRs2VQiYb4bdEHTrkkGwSMiZeM12sP2O1/nMRH68xpKvFhkMCGWlNkhi R4F4za1L7KDZdlLba8pR69+Ys/93L7sSGwy/4LK5MTU4Wd54DvtuNlx7C g==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="363454793" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="363454793" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2023 04:10:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="756326203" X-IronPort-AV: E=Sophos;i="6.01,196,1684825200"; d="scan'208";a="756326203" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001.jf.intel.com with ESMTP; 11 Jul 2023 04:10:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qJBGQ-001pHZ-2T; Tue, 11 Jul 2023 14:10:38 +0300 Date: Tue, 11 Jul 2023 14:10:38 +0300 From: Andy Shevchenko To: Mark Brown Cc: Cristian Ciocaltea , Yang Yingliang , Amit Kumar Mahapatra via Alsa-devel , Neil Armstrong , Tharun Kumar P , Vijaya Krishna Nivarthi , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org, Sanjay R Mehta , Radu Pirea , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Tudor Ambarus , Serge Semin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Andy Gross , Bjorn Andersson , Konrad Dybcio , Heiko Stuebner , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Max Filippov , Steven Rostedt , Masami Hiramatsu , Richard Cochran Subject: Re: [PATCH v2 08/15] spi: Clean up headers Message-ID: References: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> <20230710154932.68377-9-andriy.shevchenko@linux.intel.com> <54bb9fe7-fb62-4c2e-ae36-d2c10648ee27@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54bb9fe7-fb62-4c2e-ae36-d2c10648ee27@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 06:21:44PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 06:49:25PM +0300, Andy Shevchenko wrote: > > There is a few things done: > > - include only the headers we are direct user of > > - when pointer is in use, provide a forward declaration > > - add missing headers > > - group generic headers and subsystem headers > > - sort each group alphabetically > > The previous commit was supposed to be sorting things and AFAICT did > so... This is about forward declaration groups. > > +struct spi_device_id; > > Why are we adding this given that there's also an inclusion of > mod_devicetable that you didn't remove? Answered in the other email. -- With Best Regards, Andy Shevchenko